Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/auth): spin out go.mod #18351

Merged
merged 1 commit into from
Nov 7, 2023
Merged

refactor(x/auth): spin out go.mod #18351

merged 1 commit into from
Nov 7, 2023

Conversation

odeke-em
Copy link
Collaborator

@odeke-em odeke-em commented Nov 3, 2023

A Go module for x/auth at cosmossdk.io/x/auth

Updates #11899

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2023 •
edited
Loading

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

200 files out of 257 files are above the max files limit of 50.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@odeke-em odeke-em force-pushed the go.mod-spin-out-x-auth branch 6 times, most recently from a93072f to 93a6e68 Compare November 3, 2023 16:59
@odeke-em odeke-em force-pushed the go.mod-spin-out-x-auth branch 8 times, most recently from d39556c to 243f071 Compare November 7, 2023 04:20
@odeke-em odeke-em mentioned this pull request Nov 7, 2023
Closed
1 task
@odeke-em
Copy link
Collaborator Author

odeke-em commented Nov 7, 2023

I've spun up a fix for the exposed and unrelated data race in e2e->baseapp per #18383

likhita-809
likhita-809 reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the golangci-lint?
and why do we want to remove README.md from x/auth?
Left a question, otherwise lgtm.

@odeke-em odeke-em force-pushed the go.mod-spin-out-x-auth branch 2 times, most recently from 8b9d688 to a13a469 Compare November 7, 2023 06:32
@odeke-em
Copy link
Collaborator Author

odeke-em commented Nov 7, 2023

Thanks @likhita-809, golangci-lint fixed up, thanks for catching the x/auth/zREADME.md change which I've reverted. The PR is now ready for review, please take a look.

@odeke-em
refactor(x/auth): spin out go.mod
1e58fba 
A Go module for x/auth at cosmossdk.io/x/auth

Updates #11899
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

[Cosmos SDK - x/auth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

julienrbrt
julienrbrt approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@odeke-em odeke-em added this pull request to the merge queue Nov 7, 2023
@odeke-em
Copy link
Collaborator Author

odeke-em commented Nov 7, 2023

Thanks for the review @julienrbrt!

Merged via the queue into main with commit 05261cc Nov 7, 2023
78 of 81 checks passed
@odeke-em odeke-em deleted the go.mod-spin-out-x-auth branch November 7, 2023 11:46
@julienrbrt julienrbrt mentioned this pull request Sep 2, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
C:CLI C:collections C:Simulations C:x/accounts C:x/auth C:x/authz C:x/bank C:x/circuit C:x/consensus C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/upgrade Type: ADR Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odeke-em @julienrbrt @likhita-809