Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix repeated cmds in CLI for staking (v.0.24.0 release) #2043

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

fedekunze
Copy link
Collaborator

Fixes #2021

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze mentioned this pull request Aug 15, 2018
9 tasks
@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #2043 into release/v0.24.0 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/v0.24.0    #2043   +/-   ##
================================================
  Coverage            64.86%   64.86%           
================================================
  Files                  115      115           
  Lines                 6862     6862           
================================================
  Hits                  4451     4451           
  Misses                2127     2127           
  Partials               284      284

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @fedekunze

@cwgoes cwgoes merged commit c9358ec into release/v0.24.0 Aug 15, 2018
@cwgoes cwgoes deleted the fedekunze/cherrypick-v.024 branch August 15, 2018 14:59
@fedekunze fedekunze mentioned this pull request Aug 20, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants