Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor simulation changes #2068

Merged
merged 14 commits into from
Aug 17, 2018
Merged

Minor simulation changes #2068

merged 14 commits into from
Aug 17, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Aug 16, 2018


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #2068 into release/v0.24.0 will decrease coverage by 0.23%.
The diff coverage is 66.66%.

@@                 Coverage Diff                 @@
##           release/v0.24.0    #2068      +/-   ##
===================================================
- Coverage            63.97%   63.74%   -0.24%     
===================================================
  Files                  113      113              
  Lines                 6665     6669       +4     
===================================================
- Hits                  4264     4251      -13     
- Misses                2118     2133      +15     
- Partials               283      285       +2

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 17, 2018

(moved to #2063 (comment))

@cwgoes cwgoes changed the title WIP/DNM: Debug randomized simulation WIP: Temporarily disable supply invariants on simulation Aug 17, 2018
@cwgoes cwgoes changed the title WIP: Temporarily disable supply invariants on simulation WIP: Minor simulation changes Aug 17, 2018
@cwgoes cwgoes changed the title WIP: Minor simulation changes Minor simulation changes Aug 17, 2018
@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 17, 2018

Removed the quick fixes, those should go in separate PRs.

@cwgoes cwgoes merged commit b8cfc1e into release/v0.24.0 Aug 17, 2018
@cwgoes cwgoes deleted the cwgoes/debug-simulation branch August 17, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant