From 13ffbb4c888ffe61900b6d197f3831012e7d878d Mon Sep 17 00:00:00 2001 From: rigelrozanski Date: Thu, 21 Mar 2019 12:40:23 -0400 Subject: [PATCH 1/2] 303030 bug part 2 --- client/lcd/lcd_test.go | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/client/lcd/lcd_test.go b/client/lcd/lcd_test.go index caaf23593b47..d07efff55141 100644 --- a/client/lcd/lcd_test.go +++ b/client/lcd/lcd_test.go @@ -520,9 +520,16 @@ func TestBonding(t *testing.T) { // test redelegation rdTokens := sdk.TokensFromTendermintPower(30) resultTx = doBeginRedelegation(t, port, name1, pw, addr, operAddrs[0], operAddrs[1], rdTokens, fees) + require.Equal(t, uint32(0), resultTx.Code) tests.WaitForHeight(resultTx.Height+1, port) - require.Equal(t, uint32(0), resultTx.Code) + // because the second validator never signs during these tests, if this + // this test takes a long time to run, eventually this second validator + // will get slashed, meaning that it's exchange rate is no-longer 1-to-1, + // hence we utilize the exchange rate in the following test + validator2 := getValidator(t, port, operAddrs[1]) + delTokensAfterRedelegation := validator2.ShareTokens(delegatorDels[0].GetShares()) + require.Equal(t, rdTokens.ToDec(), delTokensAfterRedelegation) // verify balance after paying fees acc = getAccount(t, port, addr) @@ -547,15 +554,6 @@ func TestBonding(t *testing.T) { require.Len(t, delegatorDels, 1) require.Equal(t, operAddrs[1], delegatorDels[0].ValidatorAddress) - // because the second validator never signs during these tests, if this - // this test takes a long time to run, eventually this second validator - // will get slashed, meaning that it's exchange rate is no-longer 1-to-1, - // hence we utilize the exchange rate in the following test - - validator2 := getValidator(t, port, operAddrs[1]) - delTokensAfterRedelegation := validator2.ShareTokens(delegatorDels[0].GetShares()) - require.Equal(t, rdTokens.ToDec(), delTokensAfterRedelegation) - redelegation := getRedelegations(t, port, addr, operAddrs[0], operAddrs[1]) require.Len(t, redelegation, 1) require.Len(t, redelegation[0].Entries, 1) From 5b1e5ffeff2fad3584a2fc718498b3edcb4cbd0e Mon Sep 17 00:00:00 2001 From: rigelrozanski Date: Thu, 21 Mar 2019 13:25:39 -0400 Subject: [PATCH 2/2] further rearrange --- client/lcd/lcd_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/client/lcd/lcd_test.go b/client/lcd/lcd_test.go index d07efff55141..f7b2dd076459 100644 --- a/client/lcd/lcd_test.go +++ b/client/lcd/lcd_test.go @@ -522,12 +522,17 @@ func TestBonding(t *testing.T) { resultTx = doBeginRedelegation(t, port, name1, pw, addr, operAddrs[0], operAddrs[1], rdTokens, fees) require.Equal(t, uint32(0), resultTx.Code) tests.WaitForHeight(resultTx.Height+1, port) + validator2 := getValidator(t, port, operAddrs[1]) + + // query delegations, unbondings and redelegations from validator and delegator + delegatorDels = getDelegatorDelegations(t, port, addr) + require.Len(t, delegatorDels, 1) + require.Equal(t, operAddrs[1], delegatorDels[0].ValidatorAddress) // because the second validator never signs during these tests, if this // this test takes a long time to run, eventually this second validator // will get slashed, meaning that it's exchange rate is no-longer 1-to-1, // hence we utilize the exchange rate in the following test - validator2 := getValidator(t, port, operAddrs[1]) delTokensAfterRedelegation := validator2.ShareTokens(delegatorDels[0].GetShares()) require.Equal(t, rdTokens.ToDec(), delTokensAfterRedelegation) @@ -549,11 +554,6 @@ func TestBonding(t *testing.T) { require.Len(t, txs, 1) require.Equal(t, resultTx.Height, txs[0].Height) - // query delegations, unbondings and redelegations from validator and delegator - delegatorDels = getDelegatorDelegations(t, port, addr) - require.Len(t, delegatorDels, 1) - require.Equal(t, operAddrs[1], delegatorDels[0].ValidatorAddress) - redelegation := getRedelegations(t, port, addr, operAddrs[0], operAddrs[1]) require.Len(t, redelegation, 1) require.Len(t, redelegation[0].Entries, 1)