-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gaia #4347
Remove gaia #4347
Conversation
As a part of this PR we should remove the changelog sections "gaia" from the clog config file |
Codecov Report
@@ Coverage Diff @@
## master #4347 +/- ##
==========================================
- Coverage 58.09% 58.09% -0.01%
==========================================
Files 235 235
Lines 14880 14879 -1
==========================================
- Hits 8645 8644 -1
Misses 5607 5607
Partials 628 628 |
I would love to have the repo with gaia alone before merging |
@sabau yes, that is exactly the plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still references to Gaia that I think should be cleared up prior to merging. Namely,
- x/genutil/genesis_state.go
- x/genutil/client/cli/validate_genesis.go
- x/genutil/client/cli/init_test.go
- x/genutil/client/cli/gentx.go
- x/crisis/keeper.go
- client/lcd/root.go
- client/keys/delete.go
- client/context/errors.go
- client/config.go
- .github/ISSUE_TEMPLATE/bug-report.md
- What are we going to do with all the non-spec docs?
- What about test_cover?
We should also remove all usage of gaia
from simapp
as to not cause any confusion. Call it something else?
Minor things. Will be fixed in an ensuing PR.
What do you mean by non-spec docs? Gaia docs will be moved across the new repo in an ensuing PR.
What's wrong with |
I believe these changes are mostly minimal and should be done in this PR. I can help out with the modules. |
@alexanderbez only gaia references I see now are :
|
@alessio I believe I have taken care of everything except the docs and some aspects of the Makefile. With regards to the makefile, I believe a lot of cruft can be removed (eg. LDFLAGS). Can you do a quick pass through and clean it up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- pending Makefile cleanup.
- networks/ - moved across the new gaia repo - gaia related docker and localnet Makefile targets
603f930
to
93f2ae3
Compare
Now, I want to build and install gaia, but I do not known which repositories should use, cosmos-sdk or gaia? The Gaia repositories v0.0.0 release can used for production? |
|
Gaia is removed from cosmos-sdk repository. Few changes were required to make sure no packages depend on gaia subpackages. CI config is amended accordingly. Unnecessary targets are removed from Makefile. Simulations run through a lightweight version of gaia renamed to simapp. Closes: cosmos#4104
Gaia is removed from cosmos-sdk repository.
Few changes were required to make sure no packages depend on gaia subpackages.
CI config is amended accordingly.
Unnecessary targets are removed from Makefile.
Simulations run through a lightweight version of gaia renamed to simapp.
Closes: #4104
docs/
)clog add [section] [stanza] [message]
Files changed
in the github PR explorerFor Admin Use: