Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gaia #4347

Merged
merged 49 commits into from
May 18, 2019
Merged

Remove gaia #4347

merged 49 commits into from
May 18, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 16, 2019

Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: #4104

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski
Copy link
Contributor

As a part of this PR we should remove the changelog sections "gaia" from the clog config file

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #4347 into master will decrease coverage by <.01%.
The diff coverage is 30%.

@@            Coverage Diff             @@
##           master    #4347      +/-   ##
==========================================
- Coverage   58.09%   58.09%   -0.01%     
==========================================
  Files         235      235              
  Lines       14880    14879       -1     
==========================================
- Hits         8645     8644       -1     
  Misses       5607     5607              
  Partials      628      628

@sabau
Copy link
Contributor

sabau commented May 17, 2019

I would love to have the repo with gaia alone before merging

@alessio
Copy link
Contributor Author

alessio commented May 17, 2019

@sabau yes, that is exactly the plan

@alessio alessio marked this pull request as ready for review May 17, 2019 14:10
@alessio alessio changed the title Rremove gaia Remove gaia May 17, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references to Gaia that I think should be cleared up prior to merging. Namely,

  • x/genutil/genesis_state.go
  • x/genutil/client/cli/validate_genesis.go
  • x/genutil/client/cli/init_test.go
  • x/genutil/client/cli/gentx.go
  • x/crisis/keeper.go
  • client/lcd/root.go
  • client/keys/delete.go
  • client/context/errors.go
  • client/config.go
  • .github/ISSUE_TEMPLATE/bug-report.md

  • What are we going to do with all the non-spec docs?
  • What about test_cover?

We should also remove all usage of gaia from simapp as to not cause any confusion. Call it something else?

@alessio
Copy link
Contributor Author

alessio commented May 17, 2019

There are still references to Gaia that I think should be cleared up prior to merging. Namely,
[snip]
We should also remove all usage of gaia from simapp as to not cause any confusion. Call it something else?

Minor things. Will be fixed in an ensuing PR.

What are we going to do with all the non-spec docs?

What do you mean by non-spec docs? Gaia docs will be moved across the new repo in an ensuing PR.

What about test_cover?

What's wrong with test_cover? It seems to build correctly.

@alexanderbez
Copy link
Contributor

I believe these changes are mostly minimal and should be done in this PR. I can help out with the modules.

Makefile Outdated Show resolved Hide resolved
@rigelrozanski
Copy link
Contributor

@alexanderbez only gaia references I see now are :

genutil/client/cli/init_test.go
42:	require.NoError(t, cmd.RunE(nil, []string{"gaianode-test"}))
66:	require.NoError(t, cmd.RunE(nil, []string{"gaianode-test"}))
106:	require.NoError(t, initCmd.RunE(nil, []string{"gaianode-test"}))

@alexanderbez
Copy link
Contributor

@alessio I believe I have taken care of everything except the docs and some aspects of the Makefile. With regards to the makefile, I believe a lot of cruft can be removed (eg. LDFLAGS). Can you do a quick pass through and clean it up?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- pending Makefile cleanup.

@alessio alessio force-pushed the alessio/remove-gaia branch from 603f930 to 93f2ae3 Compare May 18, 2019 01:26
@alessio alessio merged commit 71d71f2 into master May 18, 2019
@alexanderbez alexanderbez deleted the alessio/remove-gaia branch May 24, 2019 20:57
@jualy007
Copy link

Now, I want to build and install gaia, but I do not known which repositories should use, cosmos-sdk or gaia? The Gaia repositories v0.0.0 release can used for production?

@alessio
Copy link
Contributor Author

alessio commented Jun 19, 2019

v0.0.0 is a tentative tag. gaia's master branch at this very moment hosts gaia's current development trunk. So no, it's definitely not suitable for production environments, instead I'd recommend to build gaia from a cosmos-sdk's repo release tag.

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: cosmos#4104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cmd/gaia
6 participants