Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IBC packet data interpretation to the application module #5890

Merged
merged 10 commits into from
Apr 1, 2020
Merged

Move IBC packet data interpretation to the application module #5890

merged 10 commits into from
Apr 1, 2020

Commits on Mar 31, 2020

  1. fix: move IBC packet data interpretation to the application module 

    This also adds a channelexported.NewOpaquePacketData(rawBytes)
implementation to assist apps in being able to manipulate the
raw packet data using the codec layer.
    @michaelfig
    michaelfig committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    b5070a4 View commit details
    Browse the repository at this point in the history

  2. feat: use an internal-to-module PacketDataI type 

    This one only has a GetBytes() method, which is implemented by
OpaquePacketData.
    @michaelfig
    michaelfig committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    723704f View commit details
    Browse the repository at this point in the history

  3. fix: remove OpaquePacketData 

    No need to wrap the []byte packet.GetData().  If the caller wants
it, they can use it directly.
    @michaelfig
    michaelfig committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    92038fd View commit details
    Browse the repository at this point in the history

  4. docs: update adr-015

    @michaelfig
    michaelfig committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    1000af9 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. fix: put the TimeoutHeight back into the packet commitment

    @michaelfig
    michaelfig committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    36d8c43 View commit details
    Browse the repository at this point in the history

  2. refactor: simplify unmarshalling of transfer packet

    @michaelfig
    michaelfig committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    f0cba60 View commit details
    Browse the repository at this point in the history

  3. docs: update for new unmarshal steps

    @michaelfig
    michaelfig committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    40e631f View commit details
    Browse the repository at this point in the history

  4. fix: clean up usage of sdkerrors.Wrapf

    @michaelfig
    michaelfig committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    754b4fa View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
    @michaelfig @fedekunze
    michaelfig and fedekunze authored Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c6c0598 View commit details
    Browse the repository at this point in the history

  6. chore: remove unnecessary "encoding/binary" import

    @michaelfig
    michaelfig committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    842d73d View commit details
    Browse the repository at this point in the history