x/staking: remove alias.go usage #6397
Conversation
dauTT
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6397 +/- ##
=======================================
Coverage 55.66% 55.66%
=======================================
Files 465 465
Lines 27674 27674
=======================================
Hits 15404 15404
Misses 11169 11169
Partials 1101 1101 |
simapp/app.go
Outdated
| @@ -36,6 +36,9 @@ import ( | |||
| paramproposal "github.com/cosmos/cosmos-sdk/x/params/types/proposal" | |||
| "github.com/cosmos/cosmos-sdk/x/slashing" | |||
| "github.com/cosmos/cosmos-sdk/x/staking" | |||
| stakingkeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper" | |||
| stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" | |||
|
|
|||
There was a problem hiding this comment.
Make sure these changes are formatted correctly. You can run goimports manually or, preferably, run make fmt
There was a problem hiding this comment.
Alternatively, just run:
git config core.hooksPath contrib/githooks
The git pre-commit hook will fix code formatting for you.
There was a problem hiding this comment.
Hi Alexander,
both gofmt, and goimports do not detect any formatting issue. I am using vscode with auto-formatting on save.
In addition the command make fmt does not exist. There is a command make format in the make file which also does not detect any formatting issue.
Do you want me to remove the extra line in the import manually?
There was a problem hiding this comment.
Ahh, sorry, I meant make format. Tip, you can use tab to autocomplete.
WRT to formatting, the grouping is what I'm referring to. make format should take care of this for you.
There was a problem hiding this comment.
As I said abobe, after running make format nothing happens. The file app.go didn't change at all:
There was a problem hiding this comment.
Goimport isn't smart enough to recognize this case unfortunately. Could you remove the space manually.
|
This pull request introduces 2 alerts when merging b8e8ff1 into 9048ffa - view on LGTM.com new alerts:
|
tac0turtle
added
the
A:automerge
* x/staking: remove alias.go usage * Fix formatting and Add entry in CHANGELOG.md * Add missing end curly parenthesis Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Description
This PR closes a sub task in #6311
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer