Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: change PruningDefault to KeepEvery:100 #6520

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jun 26, 2020

Change the default pruning strategy to KeepEvery:100, the same as 0.38.4. This is to reduce the chance of data loss for users blindly upgrading from 0.38.0-0.38.4, due to bugs in the IAVL pruning implementation. See 0.38.5 change log for details.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@erikgrinaker erikgrinaker self-assigned this Jun 26, 2020
@erikgrinaker erikgrinaker changed the title store: change default PruningDefault to KeepEvery:100 store: change PruningDefault to KeepEvery:100 Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #6520 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6520   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files         470      470           
  Lines       28234    28234           
=======================================
  Hits        15913    15913           
  Misses      11195    11195           
  Partials     1126     1126           

@tac0turtle tac0turtle merged commit 98a3645 into master Jun 26, 2020
@tac0turtle tac0turtle deleted the erik/pruning-default branch June 26, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants