Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate missing x/distribution CLI queries to proto #7244

Merged
merged 5 commits into from
Sep 7, 2020

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Sep 5, 2020

Description

ref: #6987


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #7244 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master    #7244   +/-   ##
=======================================
  Coverage   54.91%   54.92%           
=======================================
  Files         575      575           
  Lines       39536    39544    +8     
=======================================
+ Hits        21712    21718    +6     
- Misses      16031    16032    +1     
- Partials     1793     1794    +1     

@anilcse anilcse added the C:x/distribution distribution module related label Sep 5, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 5, 2020

This pull request introduces 1 alert when merging 28c8997 into b52ffa0 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@anilcse anilcse added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 7, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit ebfb616 into master Sep 7, 2020
@mergify mergify bot deleted the anil/6087_missing_proto branch September 7, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants