Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default historical header number for stargate #8178

Merged
merged 7 commits into from
Dec 17, 2020
Merged

Update default historical header number for stargate #8178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
915632b
Update default historical header number
jackzampolin Dec 16, 2020
dc5e0d5
Update x/staking/types/params.go
fedekunze Dec 17, 2020
2298fc5
Merge branch 'master' into jack/historical-headers
mergify[bot] Dec 17, 2020
fb66a53
Merge branch 'master' into jack/historical-headers
mergify[bot] Dec 17, 2020
04909bb
Merge branch 'master' into jack/historical-headers
mergify[bot] Dec 17, 2020
ed3f379
fix tests
fedekunze Dec 17, 2020
dc9ad41
duh
fedekunze Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x/staking/client/cli/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,15 +858,15 @@ func (s *IntegrationTestSuite) TestGetCmdQueryParams() {
"with text output",
[]string{fmt.Sprintf("--%s=text", tmcli.OutputFlag)},
`bond_denom: stake
historical_entries: 100
historical_entries: 10000
max_entries: 7
max_validators: 100
unbonding_time: 1814400s`,
},
{
"with json output",
[]string{fmt.Sprintf("--%s=json", tmcli.OutputFlag)},
`{"unbonding_time":"1814400s","max_validators":100,"max_entries":7,"historical_entries":100,"bond_denom":"stake"}`,
`{"unbonding_time":"1814400s","max_validators":100,"max_entries":7,"historical_entries":10000,"bond_denom":"stake"}`,
},
}
for _, tc := range testCases {
Expand Down
2 changes: 1 addition & 1 deletion x/staking/simulation/genesis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestRandomizedGenState(t *testing.T) {

require.Equal(t, uint32(207), stakingGenesis.Params.MaxValidators)
require.Equal(t, uint32(7), stakingGenesis.Params.MaxEntries)
require.Equal(t, uint32(48), stakingGenesis.Params.HistoricalEntries)
require.Equal(t, uint32(8687), stakingGenesis.Params.HistoricalEntries)
require.Equal(t, "stake", stakingGenesis.Params.BondDenom)
require.Equal(t, float64(238280), stakingGenesis.Params.UnbondingTime.Seconds())
// check numbers of Delegations and Validators
Expand Down
2 changes: 1 addition & 1 deletion x/staking/simulation/params_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestParamChanges(t *testing.T) {
}{
{"staking/MaxValidators", "MaxValidators", "82", "staking"},
{"staking/UnbondingTime", "UnbondingTime", "\"275307000000000\"", "staking"},
{"staking/HistoricalEntries", "HistoricalEntries", "29", "staking"},
{"staking/HistoricalEntries", "HistoricalEntries", "9149", "staking"},
}

paramChanges := simulation.ParamChanges(r)
Expand Down
4 changes: 2 additions & 2 deletions x/staking/types/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ const (
// Default maximum entries in a UBD/RED pair
DefaultMaxEntries uint32 = 7

// DefaultHistorical entries is 100. Apps that don't use IBC can ignore this
// DefaultHistorical entries is 10000. Apps that don't use IBC can ignore this
// value by not adding the staking module to the application module manager's
// SetOrderBeginBlockers.
DefaultHistoricalEntries uint32 = 100
DefaultHistoricalEntries uint32 = 10000
)

var (
Expand Down