Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: x/{auth, bank, distr} docs basic cleanup (#8268) #8304

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

atheeshp
Copy link
Contributor

  • basic code clean up

  • revert MsgVerifyInvariant

  • review changes

  • review changes

  • review changes

  • review changes

  • review changes

  • review changes

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

* basic code clean up

* revert MsgVerifyInvariant

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@atheeshp atheeshp marked this pull request as ready for review January 12, 2021 11:57
@amaury1093 amaury1093 changed the title x/{auth, bank, distr} docs basic cleanup (#8268) backport: x/{auth, bank, distr} docs basic cleanup (#8268) Jan 12, 2021
x/distribution/spec/04_messages.md Show resolved Hide resolved
x/distribution/spec/04_messages.md Outdated Show resolved Hide resolved
x/distribution/spec/04_messages.md Outdated Show resolved Hide resolved
x/distribution/spec/04_messages.md Outdated Show resolved Hide resolved
@amaury1093
Copy link
Contributor

@atheeshp Could you address Marie's reviews, and once this is merged, create a forward-port PR to update docs on master too?

@atheeshp atheeshp requested a review from blushi January 20, 2021 13:03
@amaury1093
Copy link
Contributor

@atheeshp could you rebase this PR to release/v0.41.x? Thanks

@atheeshp atheeshp changed the base branch from release/v0.40.x to release/v0.41.x January 29, 2021 05:10
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like any changes have been pushed since my last review so basically unresolving my previous comments.

x/distribution/spec/04_messages.md Show resolved Hide resolved
x/distribution/spec/04_messages.md Outdated Show resolved Hide resolved
x/distribution/spec/04_messages.md Show resolved Hide resolved
x/distribution/spec/04_messages.md Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from blushi January 29, 2021 10:37
@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. labels Jan 29, 2021
@amaury1093
Copy link
Contributor

@alessio Could you merge this PR?

@alessio alessio merged commit ba8de90 into release/v0.41.x Feb 22, 2021
@alessio alessio deleted the atheesh/docs-audit branch February 22, 2021 12:17
@alessio alessio added this to the v0.41.4 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants