types: make NewDecFromStr returns error for too large decimal #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @odeke-em |
odeke-em
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
LGTM, thank you @cuonglm! Fruits of the tree of continuous fuzzing :-) @alessio @marbar3778 please help take a look and also we might need backports as this can crash a node.
Codecov Report
@@ Coverage Diff @@
## master #9157 +/- ##
=======================================
Coverage 58.89% 58.89%
=======================================
Files 585 585
Lines 32801 32803 +2
=======================================
+ Hits 19318 19320 +2
Misses 11199 11199
Partials 2284 2284
|
Otherwise, NewDecFromStr may accept very large input, causing Dec methods panic, e.g Dec.TruncateInt Found by oss-fuzz: https://oss-fuzz.com/testcase-detail/6454129938530304 Fixes #9160
alessio
pushed a commit
that referenced
this pull request
Apr 22, 2021
9 tasks
alessio
pushed a commit
that referenced
this pull request
Apr 22, 2021
odeke-em
pushed a commit
that referenced
this pull request
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Otherwise, NewDecFromStr may accept very large input, causing Dec
methods panic, e.g Dec.TruncateInt
Found by oss-fuzz: https://oss-fuzz.com/testcase-detail/6454129938530304
Fixes #9160
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes