Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deployment #9202

Merged
merged 1 commit into from
Apr 26, 2021
Merged

docs: remove deployment #9202

merged 1 commit into from
Apr 26, 2021

Conversation

tac0turtle
Copy link
Member

Description

Change docs deployment from this repo to github.com/cosmos/docs.

This is an attempt to reduce the size of this repo.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle self-assigned this Apr 26, 2021
@tac0turtle tac0turtle added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. labels Apr 26, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. To be safe, shouldn't we make sure github.com/cosmos/docs is correctly set up first? (and docs.cosmos.network pointing to a gh-pages from that repo?)

@tac0turtle
Copy link
Member Author

this is deployed from there: https://docs.cosmos.network/. Already broke it once before it worked lol.

@amaury1093
Copy link
Contributor

Ah, cool, let's merge this then!

@tac0turtle tac0turtle merged commit 338dac4 into master Apr 26, 2021
@tac0turtle tac0turtle deleted the remove-docs branch April 26, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants