Keyring migration #9221
Closed
Keyring migration #9221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add comment on x/auth hacky migration script * QueryServer -> QueryRouter
* Set proper default command output * Removed duplicated cmd.SetErr(cmd.ErrOrStderr()) and cmd.SetOut(cmd.OutOrStdout()) * Moved command initialization and added CHANGELOG * fix: groom all uses of cmd.Print* * Ran make format Co-authored-by: Michael FIG <mfig@agoric.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.3.2 to v1.4.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.3.2...0e28ff8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
UnsafeStrToBytes is currently not safe for -d=checkptr=2, since when it cast from smaller struct (string) to bigger struct ([]byte). That causes checkptr complains as the casting straddle multiple heap objects. To fix this, we have to get the string header first, then use its fields to construct the slice. New implementation performs the same speed with the old (wrong) one. name old time/op new time/op delta UnsafeStrToBytes-8 25.7ns ± 1% 25.7ns ± 3% ~ (p=0.931 n=10+17) name old alloc/op new alloc/op delta UnsafeStrToBytes-8 7.00B ± 0% 7.00B ± 0% ~ (all equal) name old allocs/op new allocs/op delta UnsafeStrToBytes-8 0.00 0.00 ~ (all equal) While at it, also simplify UnsafeBytesToStr implementation, since when we can pass the slice directly to unsafe.Pointer, instead of getting the slice header first.
* add: arbitrary signature adr draft * fix: adr number * change: adjust scope, address feedback * fix: missing sentence * change: address wording Co-authored-by: Robert Zaremba <robert@zaremba.ch> * change: address wording and formatting Co-authored-by: Robert Zaremba <robert@zaremba.ch> * change: address formatting Co-authored-by: Robert Zaremba <robert@zaremba.ch> * change: message name, address modal verbs changes * change: document how MsgSignData should be used * change: address wording Co-authored-by: Robert Zaremba <robert@zaremba.ch> * add: how verification works * Update docs/architecture/adr-036-arbitrary-signature.md * Update docs/architecture/adr-036-arbitrary-signature.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Apply suggestions from code review * Update docs/architecture/adr-036-arbitrary-signature.md * add: expand further discussion items * fix: wording * add: context references * change: split offchain tx specific from MsgSignData Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Marko <marbar3778@yahoo.com>
Bumps [github.com/confio/ics23/go](https://github.com/confio/ics23) from 0.6.3 to 0.6.6. - [Release notes](https://github.com/confio/ics23/releases) - [Commits](cosmos/ics23@v0.6.3...go/v0.6.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.4.0 to v1.4.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.4.0...967e2b3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add basics for permanent locked vesting account support * remove sdk.Msg support for PermanentLockedVestingAccount * add tests for PermanentLockedVestingAccount * remove unecessary tests * drop unecessary create vesting acct msgs * Update x/auth/vesting/types/vesting_account.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Update x/auth/vesting/types/vesting_account.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Update x/auth/vesting/types/vesting_account.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Update x/auth/vesting/types/vesting_account_test.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Review changes * Factorize init function * Factorize more * Comments * Fix build after rename Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Aaron Craelius <aaron@regen.network>
* add governance hooks * fix lint * fix lint * CHANGELOG * sh -> gh * improve comments * add test * add more tests * rename two of the hooks Co-authored-by: ahmedaly113 <ahmedaly113@outlook.com>
…#9163) Ensure that we don't pass overflowed values into make, because a clever attacker could see that to cause: (bits+7)/8 to become negative, they just have to make (bits+7) become negative simply by >=maxint-6 but also reject unreasonably large element count like >2**32, which while arbitrary is super duper large for a bit array. Fixes #9162
…9167) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.20.0 to 0.21.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.20.0...v0.21.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Conversation in the gaia discord seems to merit an update to the ADR committee. I haven't spoken to any of the individuals to confirm their interest or availability but I'd like to use this as a more productive forum to push the conversation further. Especially looking for comment from those proposed (@marbar3778 @ebuchman @robert-zaremba @AmauryM @zmanian @sunnya97 @fedekunze @odeke-em )
Otherwise, NewDecFromStr may accept very large input, causing Dec methods panic, e.g Dec.TruncateInt Found by oss-fuzz: https://oss-fuzz.com/testcase-detail/6454129938530304 Fixes #9160
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
the getting started link is busted, how about we send folks to Starport? and fix a few minor editorial nits
* WIP on refactoring new integration tests.
* godocs
* godocs
* Fix ineff assign
* Updates
* Updates
* fix test
* refactor crisis, distr testsuites
* fix import issue
* refactor x/auth
* refactor x/authz
* refactor x/evidence
* refactor x/feegrant
* refactor x/genutil
* refactor x/gov
* refactor x/mint
* refactor x/params
* refactor x/{auth_vesting, slashing, staking}
* fix lint
* fix tests & lint
* fix lint
* fix tests
* lint
* lint
* fix lint memory
* add missing `norace` build flag
* update feegrant cfg
* fix lint
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
) Bumps [github.com/armon/go-metrics](https://github.com/armon/go-metrics) from 0.3.6 to 0.3.7. - [Release notes](https://github.com/armon/go-metrics/releases) - [Commits](hashicorp/go-metrics@v0.3.6...v0.3.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Bumps [github.com/grpc-ecosystem/go-grpc-middleware](https://github.com/grpc-ecosystem/go-grpc-middleware) from 1.2.2 to 1.3.0. - [Release notes](https://github.com/grpc-ecosystem/go-grpc-middleware/releases) - [Changelog](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/CHANGELOG.md) - [Commits](grpc-ecosystem/go-grpc-middleware@v1.2.2...v1.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove IBC ADRs * remove ADR references from README Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* setup: reuses proto container * push docker image * set image name * revert and use latest Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
removed secondary entirely
Proposal for expanding the ADR committee
…#9201) Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* simulation genesis changes * update msg types * refactor * update operations test * fix sims * fix tests * fix tests * address review changes Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Updates to Genesis * Move grpc_query tests to keeper pkg * Unify CLI command usage message * Use timestamp for time based expiration in cli * Update FlagExpiration * Update wording * Add test case for invalid expiration * Update cli Long description * Update exp date examples * Use constants
* Add labeler action * Update .github/labeler.yml Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * Update .github/labeler.yml Co-authored-by: Cory <cjlevinson@gmail.com> * update labels * update labels * Update .github/labeler.yml Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * update labels Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* update contributor docs * revert changes to release section * fix formatting Co-authored-by: Marko <marbar3778@yahoo.com>
* Squashed commit of the following:
commit 58dc50051226a9eeb8d0ebea5bb0908fe5b9637f
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 15:09:27 2021 -0700
remove comments
commit a84107e1b3eaa31324cb0f4f097b49f02af79c69
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 15:02:41 2021 -0700
add tests for msgs.go
commit 2ad16869237e9631b402c93cde650c3fc554daf2
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 13:20:21 2021 -0700
specify test name
commit b7121277c9be586a7c80d010ec401e50b510e02a
Merge: c0c134d971 3c65c3d
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 12:54:55 2021 -0700
Merge branch 'master' into ty-9115-types_tests
commit c0c134d97107194dc4f9d3c501a15d023ae083e5
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Thu Apr 22 19:59:11 2021 -0700
-add test case to cli_test.go for filtered fee
-clean up identifiers
-remove redundant import alias from filtered_fee.go
commit f7ab3699da39be3ab886f96962d28d23438d2e8e
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Thu Apr 22 09:57:31 2021 -0700
remove unecessary constant
commit 9db59a82a7337cf5a7a3569c6900a44a6c81e8b4
Merge: a3e75ceb8a e28271b
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Thu Apr 22 09:19:20 2021 -0700
Merge branch 'master' into ty-9115-types_tests
commit a3e75ceb8a510ad9db43dd96073c43b7a8b062b0
Merge: 4d3dafab85 bffcae5
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Wed Apr 21 12:04:39 2021 -0700
Merge branch 'master' into ty-9115-types_tests
commit 4d3dafab85d85526a7c94b045289605289ee6b0d
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Wed Apr 21 12:03:41 2021 -0700
cleanup id's / add test case
commit e8f6924931ba95e592bfc3057ba167700458da41
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Wed Apr 21 10:55:29 2021 -0700
add test for 0 allowance / remove unused field on exp test
commit 516b6ef89a4582ad681cc6c5c101cf50a9a54fb5
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Tue Apr 20 15:22:48 2021 -0700
make names more clear, remove unused field
* fix imports
* fix tests
* rename test field
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
* replace panic with error * improve test coverage * add time based tests to basic-fee * add periodic fee tests * wip * add msg_server tests * improve getFeeGrant * fix failing test * fix test * fix comments * refactor * review changes * review changes * fix errors * Update x/feegrant/types/basic_fee_test.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * review changes Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closed
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes