Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Support multi-signature for ethsecp256k1.PubKey #718

Closed
wants to merge 1 commit into from

Conversation

ylsGit
Copy link

@ylsGit ylsGit commented Jan 13, 2021

Closes: #716

This PR will be valid with the dependency of the modification: tendermint/tendermint#5898

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ylsGit ylsGit requested review from fedekunze and noot as code owners January 13, 2021 11:56
@ylsGit ylsGit changed the title fix issue#716 Support multi-signature for ethsecp256k1.PubKey Jan 14, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Mar 1, 2021
@fedekunze fedekunze added Status: On Ice and removed stale stale PRs that will be closed if no further action occurs labels Mar 1, 2021
@fedekunze
Copy link
Contributor

Closing as the Tendermint PR wasn't incorporated

@fedekunze fedekunze closed this Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faild to add a multisig key by the --multisig flag
2 participants