fix: typo in comment #386
Merged
fix: typo in comment #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: non-eip-155 tx panic when get signer Closes: cosmos#280 * treat zero chainID differently * fix zero check * fix comment * fix conditon
mmsqe
reviewed
Jul 31, 2025
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
yihuang
changed the title
aljo242
approved these changes
Aug 6, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* fix: non-eip-155 tx panic when get signer (cosmos#282) * fix: non-eip-155 tx panic when get signer Closes: cosmos#280 * treat zero chainID differently * fix zero check * fix comment * fix conditon * Update api/cosmos/evm/vm/v1/msg.go Co-authored-by: mmsqe <tqd0800210105@gmail.com> --------- Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #280
Re-open since it's reverted.
Hope we can prioritize this one, because we are actively testing non-eip-155 transactions.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md