feat: remove x/authz dependency from precompiles #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudgray
changed the title
cloudgray
changed the title
dongsam
reviewed
Apr 11, 2025
9 tasks
zsystm
reviewed
Apr 17, 2025
Contributor
There was a problem hiding this comment.
Looks good to me so far — the authz removal seems to be handled well.
I had one question while reviewing the test code, which I left as a comment.
Also, this is not directly related to the scope of your PR, but I noticed that some of the existing test cases don’t validate balance changes. For example, after a delete, there’s no assertion checking whether the delegator’s balance was reduced accordingly. Since the precompiled contract involves complex state transitions, I think it would be valuable to add more thorough state validation to ensure the transitions happen as expected.
This can probably be addressed in a separate PR, so just leaving this here for reference. I opened an issue to track it.
* feat(x/erc20): add allowance state * test(x/erc20): add unit test for Allowance * fix(x/erc20): add deleteAllowances method and modify genesis validation * fix(x/erc20): validation of SetAllowance/GetAllowance and InitGenesis * test(x/erc20) add test cases for UnsafeSetAllowance * chore: fix lint
fix owner == sender case
dongsam
reviewed
Apr 23, 2025
dongsam
reviewed
Apr 23, 2025
dudong2
reviewed
Apr 28, 2025
Contributor
Author
applied in dc225a2 |
Eric-Warehime
added a commit
that referenced
this pull request
Jul 17, 2025
chore: merge backport pr #62
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* feat: remove authz dependency from precompiles except for erc20 * wip: feat(precompiles): remove x/authz dependency * test(precompiles): remove x/authz dependent test cases * feat: remove x/authz dependency from x/erc20 and werc20 precompile * fix(precompiles): modify contract interface and test contracts * fix(precompiles): remove unused authz related types and test utils * fix(precompiles): modify integration test of staking precompile * feat(x/erc20): add allowance state (cosmos#90) * feat(x/erc20): add allowance state * test(x/erc20): add unit test for Allowance * fix(x/erc20): add deleteAllowances method and modify genesis validation * fix(x/erc20): validation of SetAllowance/GetAllowance and InitGenesis * test(x/erc20) add test cases for UnsafeSetAllowance * chore: fix lint * wip: test: modify erc20 precompile tests * test: modify erc20 precompile tests * test(precompiles): �fix integration test fix owner == sender case * refactor(precompiles): remove authz dependent naming and comments * wip: test(x/vm): modify flashLoan test * test(x/vm): fix flashLoan integration test * fix: merge conflict * chore: fix lint * chore: fix lint * feat: remove authz keeper dependency from x/erc20 keeper * chore: fix lint * fix: increase consensusVersion of x/erc20 module * chore: udpate CHANGELOG.md * chore: update CHANGELOG.md * chore: add comments to StakingCaller solidity contract * fix: typo * fix: remove duplicated test case * fix: wrong args for ApprovalEvent * fix: wrong error message for test * refactor: refine code for staking precompile * fix: merge conflicts * refactor: change file name * refactor(testutil): move constants for test to testutil/constants package * refactor(erc20): InitGenesis * test(erc20): add genesis test case * fix(erc20): revert consensusVersion change * refactor(erc20): refactor keeper methods of Allowance state * test(testutil): fix test case and lint * wip: fix(precompiles/erc20): remove incompatible logic with ERC20 Specification * fix: add Approval event to transferFrom method and fix integration tests * fix: FlashLoan.sol contract * fix(x/erc20): allowance methods and test cases * test(precompiles): add test cases for erc20 precompile --------- Co-authored-by: Vlad <vladjdk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removal of x/authz dependency on precompiles
Approve,Revoke,IncreaseAllowance,DecreaseAllowance,Allowance) and its usage.Allowancestate CRUD methods in x/erc20 moduleAllowancestate of x/erc20 module instead ofGrantstate of x/authz module for authorization methods (Approve,Revoke,IncreaseAllowance,DecreaseAllowance,Allowance)Closes: #47
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md