Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor Hermes relayers setups and executions in the E2E tests #2859

Merged
merged 4 commits into from
Feb 8, 2024
Merged

chore: refactor Hermes relayers setups and executions in the E2E tests #2859

merged 4 commits into from
Feb 8, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Dec 15, 2023

Description

Will be merged after #2852.

Closes: #2570

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke marked this pull request as draft January 4, 2024 15:46
@sainoe sainoe force-pushed the sainoe/e2e-hermes-refactoring branch from 6408598 to 099fcc7 Compare January 29, 2024 10:52
@sainoe sainoe force-pushed the sainoe/e2e-hermes-refactoring branch from efccbef to 0099af5 Compare February 1, 2024 15:02
@sainoe sainoe marked this pull request as ready for review February 1, 2024 15:02
MSalopek
MSalopek approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I added a commit to appease the linter

p-offtermatt
p-offtermatt approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSalopek MSalopek merged commit a92d206 into main Feb 8, 2024
18 checks passed
@MSalopek MSalopek deleted the sainoe/e2e-hermes-refactoring branch February 8, 2024 10:30
mergify bot pushed a commit that referenced this pull request Feb 8, 2024
@sainoe @mergify
chore: refactor Hermes relayers setups and executions in the E2E tests (
cee9e01 
#2859)

* refactor hermes setup in e2e tests

* chore: appease linter

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit a92d206)
@mergify mergify bot mentioned this pull request Feb 8, 2024
Merged
MSalopek pushed a commit that referenced this pull request Feb 8, 2024
@mergify @sainoe
chore: refactor Hermes relayers setups and executions in the E2E tests (
c09138d 
#2859) (#2931)

* refactor hermes setup in e2e tests

* chore: appease linter

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit a92d206)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@MSalopek MSalopek MSalopek approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@zmanian zmanian Awaiting requested review from zmanian zmanian is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@jackzampolin jackzampolin Awaiting requested review from jackzampolin jackzampolin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: e2e ibc test
3 participants
@sainoe @MSalopek @p-offtermatt