Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deletion of latest saved version #482

Closed
yihuang opened this issue Mar 11, 2022 · 2 comments
Closed

Support deletion of latest saved version #482

yihuang opened this issue Mar 11, 2022 · 2 comments

Comments

@yihuang
Copy link
Collaborator

yihuang commented Mar 11, 2022

When we try to implement the rollback command in cosmos-sdk, we want to delete the latest saved version, but that's not allowed in the current version of iavl, what's the reason for that, and is it possible to relax that restriction?
yihuang added a commit to yihuang/iavl that referenced this issue Mar 11, 2022
@yihuang
relax the restriction of delete latest version
cbd14fa 
Closes: cosmos#482
@yihuang yihuang mentioned this issue Mar 11, 2022
Closed
yihuang added a commit to yihuang/iavl that referenced this issue Mar 11, 2022
@yihuang
relax the restriction of delete latest version
6fbfb5c 
Closes: cosmos#482
yihuang added a commit to yihuang/iavl that referenced this issue Mar 11, 2022
@yihuang
relax the restriction of delete latest version
ceb80dd 
Closes: cosmos#482
yihuang added a commit to yihuang/iavl that referenced this issue Mar 11, 2022
@yihuang
relax the restriction of delete latest version
de3e0a4 
Closes: cosmos#482

Update nodedb.go

changelog
@tac0turtle
Copy link
Member

@yihuang do you still need this?

@yihuang
Copy link
Collaborator Author

yihuang commented Jul 18, 2022

@yihuang do you still need this?

I think LoadVersionForOverwriting do just that, although it's very slow to run in a big db.

@yihuang yihuang closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relax the restriction of delete latest version yihuang/iavl
2 participants
@yihuang @tac0turtle