Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Makefile to run rules for all submodules. #4205

Closed
2 of 3 tasks
DimitrisJim opened this issue Jul 31, 2023 · 2 comments
Closed
2 of 3 tasks

Adjust Makefile to run rules for all submodules. #4205

DimitrisJim opened this issue Jul 31, 2023 · 2 comments
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jul 31, 2023 •
edited
Loading

Summary

The linting rules we currently have assume no submodules in the project. Since there's a couple submodules that will be introduced Soon™ we should adjust the Makefile to take them into consideration.

Note that CI currently does have workflows for each module (which build + test, no lint though).

Looking through the sdk's Makefile, I think we should be able to adjust some of the work from there.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added the type: code hygiene Clean up code but without changing functionality or interfaces label Jul 31, 2023
@DimitrisJim DimitrisJim mentioned this issue Jul 31, 2023
Merged
9 tasks
@damiannolan
Copy link
Member

Soon™

@DimitrisJim DimitrisJim mentioned this issue Aug 16, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 14, 2023
@DimitrisJim
Copy link
Contributor Author

lint and test both are executed for all modules, closing as completed.

@github-project-automation github-project-automation bot moved this from Backlog to Done in ibc-go Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damiannolan @DimitrisJim