Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sendTransfer to iterate over an array of coins #5801

Closed
Tracked by #5793
chatton opened this issue Feb 1, 2024 · 1 comment
Closed
Tracked by #5793

Update sendTransfer to iterate over an array of coins #5801

chatton opened this issue Feb 1, 2024 · 1 comment
Assignees
@crodriguezvega
Labels
20-transfer
Milestone
ICS20 v2 (multi d...

Comments

@chatton
Copy link
Contributor

chatton commented Feb 1, 2024 •
edited
Loading

The approach taken in the PoC is again to only handle the case where we have a slice of sdk.Coin, if we are receiving a message that has the old token field populated, we create a slice of one item and execute the same code path.

implementation here
@chatton chatton mentioned this issue Feb 1, 2024
Closed
24 tasks
@crodriguezvega crodriguezvega added this to the ICS20 v2 milestone Feb 1, 2024
@charleenfei charleenfei self-assigned this Apr 9, 2024
@charleenfei charleenfei changed the title [ICS20-2] Update sendTransfer to iterate over an array of coins. [ICS20-2] Update sendTransfer to iterate over an array of coins Apr 9, 2024
@charleenfei charleenfei changed the title [ICS20-2] Update sendTransfer to iterate over an array of coins Update sendTransfer to iterate over an array of coins Apr 9, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Apr 11, 2024
@charleenfei charleenfei mentioned this issue Apr 15, 2024
Merged
10 tasks
@charleenfei charleenfei moved this from Todo 🏃 to In progress 👷 in ibc-go Apr 16, 2024
@charleenfei charleenfei moved this from In progress 👷 to Todo 🏃 in ibc-go Apr 16, 2024
@charleenfei charleenfei moved this from Todo 🏃 to In progress 👷 in ibc-go Apr 16, 2024
@charleenfei charleenfei removed their assignment Apr 16, 2024
@charleenfei charleenfei removed the status in ibc-go Apr 16, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Apr 17, 2024
@crodriguezvega crodriguezvega mentioned this issue Apr 22, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega self-assigned this Apr 25, 2024
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In progress 👷 in ibc-go Apr 25, 2024
@crodriguezvega crodriguezvega moved this from In progress 👷 to In review 👀 in ibc-go May 3, 2024
@crodriguezvega
Copy link
Contributor

Closed by #6189

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
20-transfer
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) alpha
Development

No branches or pull requests
3 participants
@crodriguezvega @chatton @charleenfei