You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue contains misc. points that have come up and need to be addressed before this feature can be shipped.
GetEscrowAddress uses a hardcoded string with value ics20-1. Reason if this could be changed without breaking backwards compatibility. (See which test(s) failed when changing this constant)
Need to make decision about: adding a new MsgTransferV2 with tokens (and no token field) or use existing MsgTransfer , add the tokens field and deprecate (and later remove) field token.
Maybe for the ICS20V1 and ICS20V2 const strings we could have an enum ICS20Versions with two values V1 and V2.
Add validation for the Token trace in packet v2 ValidateBasic
The text was updated successfully, but these errors were encountered:
GetEscrowAddress uses a hardcoded string with value ics20-1. Reason if this could be changed without breaking backwards compatibility. (See which test(s) failed when changing this constant)
Beyond backwards compatibility concerns, there was also a lot of address collision concerns pre-launch. The existing constant was verified not to have address collisions, so I'd suggest we leave as is. I'm unsure how outdated that discussion is, but best to not fix something that isn't broken
This issue contains misc. points that have come up and need to be addressed before this feature can be shipped.
The text was updated successfully, but these errors were encountered: