Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICS20-2] Add conversion function between v1 packet data and v2 packet data #6114

Closed
Tracked by #5793
chatton opened this issue Apr 8, 2024 · 1 comment
Closed
Tracked by #5793

[ICS20-2] Add conversion function between v1 packet data and v2 packet data #6114

chatton opened this issue Apr 8, 2024 · 1 comment
Assignees
@chatton
Labels
20-transfer
Milestone
ICS20 v2 (multi d...

Comments

@chatton
Copy link
Contributor

chatton commented Apr 8, 2024 •
edited
Loading

POC implementation here

Note: the extractPathAndBaseFromFullDenomSlice fn was copied from elsewhere the in the codebase and stripped down, so this should be cleaned up as part of the PR
@chatton chatton mentioned this issue Apr 8, 2024
Closed
24 tasks
@chatton chatton self-assigned this Apr 8, 2024
@chatton chatton added this to the ICS20 v2 milestone Apr 8, 2024
@chatton chatton mentioned this issue Apr 9, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this to In review 👀 in ibc-go Apr 11, 2024
@charleenfei charleenfei moved this from In review 👀 to Done 🥳 in ibc-go Apr 16, 2024
@crodriguezvega
Copy link
Contributor

Closed by #6116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
20-transfer
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) alpha
Development

No branches or pull requests
2 participants
@crodriguezvega @chatton