Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add query flags to command for querying counterparty address #1313

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

I added the query flags to the CLI to query the counterparty address so that flag --node works.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... looks like this must have gotten accidentally removed in a merge conflict. Nice catch!

0347b36#diff-0f8f49c5710053cd1554c51b68aaa6bc9b7e0e9d0a38cef8aaa1cd5f7f2c683dR188

@crodriguezvega
Copy link
Contributor Author

Weird... looks like this must have gotten accidentally removed in a merge conflict. Nice catch!

0347b36#diff-0f8f49c5710053cd1554c51b68aaa6bc9b7e0e9d0a38cef8aaa1cd5f7f2c683dR188

Hmm... yeah, git sometimes can be mischievous with merging... 👿

@crodriguezvega crodriguezvega merged commit f962485 into main Apr 29, 2022
@crodriguezvega crodriguezvega deleted the carlos/queryflags-counterparty-address branch April 29, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants