Return error if fee module is locked before distributing fees on acknowledgement and timeout

[vuong177]

Description

• Return error if fee module is locked
• Move DeleteFeesInEscrow into DistributePacketFees func

closes: #1320

[codecov-commenter]

Codecov Report

Merging #1340 (e4adbd9) into main (ce7ac2e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   80.27%   80.33%   +0.05%     
==========================================
  Files         166      166              
  Lines       12023    12072      +49     
==========================================
+ Hits         9652     9698      +46     
- Misses       1916     1918       +2     
- Partials      455      456       +1     

Impacted Files	Coverage Δ
modules/apps/29-fee/ibc_middleware.go	93.50% <100.00%> (-1.67%)	⬇️
modules/apps/29-fee/keeper/escrow.go	93.78% <100.00%> (+0.41%)	⬆️
modules/apps/29-fee/keeper/keeper.go	92.43% <0.00%> (+0.08%)	⬆️
modules/core/keeper/msg_server.go	58.29% <0.00%> (+0.09%)	⬆️
modules/apps/transfer/keeper/grpc_query.go	78.57% <0.00%> (+0.31%)	⬆️
modules/apps/29-fee/types/msgs.go	89.77% <0.00%> (+0.48%)	⬆️
...7-interchain-accounts/controller/ibc_middleware.go	87.03% <0.00%> (+0.49%)	⬆️
modules/apps/transfer/ibc_module.go	63.88% <0.00%> (+0.76%)	⬆️
... and 1 more

[crodriguezvega]

Hey @vuong177, thanks for opening these PRs! I see that you're with Notional as well, just as @catShaark, right? Do you mind to reach me on Discord (I am Carlos | Interchain#9176) and we can talk about how to make your experience of contributing to ibc-go the best possible?

[vuong177]

Hey @vuong177, thanks for opening these PRs! I see that you're with Notional as well, just as @catShaark, right? Do you mind to reach me on Discord (I am Carlos | Interchain#9176) and we can talk about how to make your experience of contributing to ibc-go the best possible?

Yes. @catShaark and me are working at Notional. I'll contact you in discord.

[seantking]

Looking good just a few nits :)

Also, can you add a changelog entry?

[vuong177]

Looking good just a few nits :)

Also, can you add a changelog entry?

@seantking thank you, i make code cleaner && updated changelog.

[seantking]

Thanks! Great job!

[colin-axner]

See comment below. The error should be removed from both distribution functions

[colin-axner]

I will open a pr with my suggested improvements since I think many of them come from insufficiency in the testing code we should have previously had

[colin-axner]

see pr

[vuong177]

thank you @colin-axner, i learn a lot from your reviews.

[colin-axner]

Thanks @vuong177! Just needs to be brought up to date with main