-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cli params ordering ics29 #1353
Conversation
modules/apps/29-fee/client/cli/tx.go
Outdated
@@ -101,10 +101,10 @@ func NewPayPacketFeeAsyncTxCmd() *cobra.Command { | |||
// NewRegisterCounterpartyAddress returns the command to create a MsgRegisterCounterpartyAddress | |||
func NewRegisterCounterpartyAddress() *cobra.Command { | |||
cmd := &cobra.Command{ | |||
Use: "register-counterparty [address] [counterparty-address] [channel-id] [port-id]", | |||
Use: "register-counterparty [address] [counterparty-address] [port-id] [channel-id]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe start with port-id
& channel-id
instead of the addresses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point... maybe yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's start indeed with port-id
and channel-id
. That's the order we have for transfer: simd tx ibc-transfer transfer [src-port] [src-channel] [receiver] [amount]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @seantking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Agree on arg re-ordering. Feel free to re-request review or merge when you're happy 👍
Description
closes: #(#1339 (comment))
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes