feat: adding RegisteredPayees to ics29 genesis state #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Store funcs, keys..
damiannolan
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner,
crodriguezvega and
chatton
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
- Coverage 80.36% 80.33% -0.04%
==========================================
Files 166 166
Lines 12105 12238 +133
==========================================
+ Hits 9728 9831 +103
- Misses 1920 1946 +26
- Partials 457 461 +4
|
AdityaSripal
approved these changes
Jun 7, 2022
modules/apps/29-fee/types/genesis.go
Outdated
| @@ -77,5 +85,20 @@ func (gs GenesisState) Validate() error { | |||
| } | |||
| } | |||
|
|
|||
| // Validate DistributionAddresses | |||
| for _, registeredDistAddr := range gs.RegisteredDistributionAddresses { | |||
| if _, err := sdk.AccAddressFromBech32(registeredDistAddr.Address); err != nil { | |||
There was a problem hiding this comment.
also for DistributionAddress
damiannolan
changed the title
AdityaSripal
reviewed
Jun 8, 2022
Comment on lines
+20
to
+23
| repeated RegisteredPayee registered_payees = 3 | ||
| [(gogoproto.moretags) = "yaml:\"registered_payees\"", (gogoproto.nullable) = false]; | ||
| // list of registered relayer addresses | ||
| repeated RegisteredRelayerAddress registered_relayers = 3 | ||
| repeated RegisteredRelayerAddress registered_relayers = 4 |
There was a problem hiding this comment.
Why are there two of these? Shouldn't there be RegisteredPayees and RegisteredCounterpartyPayees?
There was a problem hiding this comment.
Yep, will be done in a follow up. Didn't want to mix the renaming of the counterparty address rpc with this!
Co-authored-by: Aditya <adityasripal@gmail.com>
…-go into damian/1477-genesis-distaddrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RegisteredPayeesto ICS29GenesisStateNeeds: #1491
This PR includes the additions from the above and should be merged after the initial work in #1491
NOTE: this is one of many PRs to complete the feature work referenced in: #1477
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes