Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move ics20 docs from spec to top level docs #1554

Merged
merged 9 commits into from
Jun 23, 2022
Merged

docs: move ics20 docs from spec to top level docs #1554

merged 9 commits into from
Jun 23, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #652

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crodriguezvega crodriguezvega linked an issue Jun 17, 2022 that may be closed by this pull request
move ics20 docs from spec to top level docs #652
Closed
3 tasks
damiannolan
damiannolan approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on catching all them typos!
LGTM!

charleenfei
charleenfei approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

seantking
seantking approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@seantking seantking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@crodriguezvega crodriguezvega merged commit a7d6090 into main Jun 23, 2022
@crodriguezvega crodriguezvega deleted the carlos/issue#652-move-ics20-docs-from-spec-to-top-level-docs branch June 23, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleenfei charleenfei charleenfei approved these changes

@seantking seantking seantking approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@fedekunze fedekunze Awaiting requested review from fedekunze

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move ics20 docs from spec to top level docs
4 participants
@crodriguezvega @damiannolan @seantking @charleenfei