Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding team members to 02-client and light-clients code owners #1563

Merged
merged 6 commits into from
Jun 23, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega changed the title adding team members to 02-client and 07-tendermint code owners adding team members to 02-client and light-clients code owners Jun 22, 2022
Comment on lines +19 to +22
## CODEOWNERS for core/02-client

/modules/core/02-client @seantking @damiannolan
/proto/ibc/core/client @seantking @damiannolan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does /modules/core take a precedence over this or vice versa?
i.e. Should these lines include the existing codeowners?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reading the code owners docs in GitHub and in theory the code owners in the higher level directory should have also still code ownership on the subdirectories... I can just add the full list of code owners here just in case, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is not true. When I look at the 02-client directory, only @seantking and @damiannolan are code owners. You will need to add all code owners (later declarations take precedence over default owners)

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should can be another PR -- but should we just add the whole engineering team to be codeowners for docs?

@crodriguezvega
Copy link
Contributor Author

maybe this should can be another PR -- but should we just add the whole engineering team to be codeowners for docs?

Yeah, that sounds good to me! I will open another PR soon!

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@crodriguezvega crodriguezvega merged commit 20ffa6f into main Jun 23, 2022
@crodriguezvega crodriguezvega deleted the carlos/update-02-client-07-tendermint-codeowners branch June 23, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants