-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding team members to 02-client and light-clients code owners #1563
adding team members to 02-client and light-clients code owners #1563
Conversation
## CODEOWNERS for core/02-client | ||
|
||
/modules/core/02-client @seantking @damiannolan | ||
/proto/ibc/core/client @seantking @damiannolan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does /modules/core
take a precedence over this or vice versa?
i.e. Should these lines include the existing codeowners?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading the code owners docs in GitHub and in theory the code owners in the higher level directory should have also still code ownership on the subdirectories... I can just add the full list of code owners here just in case, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not true. When I look at the 02-client directory, only @seantking and @damiannolan are code owners. You will need to add all code owners (later declarations take precedence over default owners)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should can be another PR -- but should we just add the whole engineering team to be codeowners for docs?
Yeah, that sounds good to me! I will open another PR soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes