-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding team members to 02-client and light-clients code owners #1563
Merged
crodriguezvega
merged 6 commits into
main
from
carlos/update-02-client-07-tendermint-codeowners
Jun 23, 2022
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0559105
adding team members to 02-client and 07-tendermint code owners
crodriguezvega 1a9ca56
review comment
crodriguezvega d2ab300
Merge branch 'main' into carlos/update-02-client-07-tendermint-codeow…
crodriguezvega 42a663d
Merge branch 'main' into carlos/update-02-client-07-tendermint-codeow…
crodriguezvega 39a3e78
Merge branch 'main' into carlos/update-02-client-07-tendermint-codeow…
crodriguezvega 568f28d
Merge branch 'main' into carlos/update-02-client-07-tendermint-codeow…
crodriguezvega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
/modules/coretake a precedence over this or vice versa?i.e. Should these lines include the existing codeowners?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading the code owners docs in GitHub and in theory the code owners in the higher level directory should have also still code ownership on the subdirectories... I can just add the full list of code owners here just in case, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not true. When I look at the 02-client directory, only @seantking and @damiannolan are code owners. You will need to add all code owners (later declarations take precedence over default owners)