Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the lint errors regarding leading spaces in //nolint directives #1893

Closed
wants to merge 2 commits into from

Conversation

crodriguezvega
Copy link
Contributor

Description

This fixes the errors with leading spaces in //nolint directives.
However, I don't know how to fix the "File is not gofmt-ed with -s (gofmt)" errors. I tried to run gofmt in the files but no changes were made...

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

Codecov Report

Merging #1893 (f2b774b) into main (af4e651) will decrease coverage by 0.12%.
The diff coverage is 64.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
- Coverage   80.04%   79.92%   -0.13%     
==========================================
  Files         166      166              
  Lines       12421    12432      +11     
==========================================
- Hits         9943     9936       -7     
- Misses       2013     2028      +15     
- Partials      465      468       +3     
Impacted Files Coverage Δ
cmd/build_test_matrix/main.go 70.83% <0.00%> (-3.46%) ⬇️
...27-interchain-accounts/controller/keeper/keeper.go 94.73% <ø> (ø)
.../apps/27-interchain-accounts/host/keeper/keeper.go 83.33% <ø> (ø)
modules/apps/27-interchain-accounts/module.go 55.55% <0.00%> (-2.14%) ⬇️
modules/apps/29-fee/keeper/keeper.go 92.48% <ø> (ø)
modules/apps/29-fee/module.go 54.54% <0.00%> (-1.02%) ⬇️
modules/apps/transfer/keeper/keeper.go 91.17% <ø> (ø)
modules/apps/transfer/keeper/migrations.go 93.10% <ø> (-0.23%) ⬇️
modules/apps/transfer/keeper/relay.go 88.11% <0.00%> (ø)
modules/apps/transfer/module.go 57.14% <0.00%> (-0.93%) ⬇️
... and 47 more

Copy link
Contributor

@seantking seantking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@damiannolan
Copy link
Member

Hey @crodriguezvega, I've taken your changes from #1892 and included in this PR which seems to resolve the golang-ci lint failures.

#1894

@crodriguezvega
Copy link
Contributor Author

Closed in favor of #1894

@crodriguezvega crodriguezvega deleted the carlos/fix-lint-errors-in-ci branch February 9, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants