Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refactor contributing guidelines - add release management #2711

Merged
merged 2 commits into from
Jan 19, 2023
Merged

docs: refactor contributing guidelines - add release management #2711

merged 2 commits into from
Jan 19, 2023

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crodriguezvega crodriguezvega mentioned this pull request Nov 8, 2022
Merged
9 tasks
colin-axner
colin-axner approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thank you!

Hopefully we can soon remove notices about changelog entry handling!

docs/dev/release-management.md Outdated Show resolved Hide resolved
chatton
chatton approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @crodriguezvega

@crodriguezvega crodriguezvega merged commit 2d5f3c8 into carlos/1747-readme-revamp-contributing Jan 19, 2023
@crodriguezvega crodriguezvega deleted the carlos/1747-contributing-release-management branch January 19, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatton chatton chatton approved these changes

@colin-axner colin-axner colin-axner approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@charleenfei charleenfei Awaiting requested review from charleenfei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crodriguezvega @damiannolan @chatton @colin-axner