Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use diffs to make registration more clear #2927

Merged
merged 2 commits into from
Dec 14, 2022
Merged

chore: use diffs to make registration more clear #2927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8237135
chore: use diffs to make registration more clear
colin-axner Dec 12, 2022
775f93c
Merge branch 'main' into colin/update-docs
colin-axner Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/ibc/integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ All light clients must be registered with `module.BasicManager` in a chain's app

The following code example shows how to register the existing `ibctm.AppModuleBasic{}` light client implementation.

```go
```diff

import (
...
ibctm "github.com/cosmos/ibc-go/v6/modules/light-clients/07-tendermint"
+ ibctm "github.com/cosmos/ibc-go/v6/modules/light-clients/07-tendermint"
...
)

Expand All @@ -55,7 +55,7 @@ var (
transfer.AppModuleBasic{}, // i.e ibc-transfer module

// register light clients on IBC
ibctm.AppModuleBasic{},
+ ibctm.AppModuleBasic{},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should make it very clear what line of code to add

)

// module account permissions
Expand Down