ChanUpgradeTimeout msg_server function

modules/apps/27-interchain-accounts/controller/ibc_middleware.go

@@ -246,19 +246,6 @@ func (im IBCMiddleware) OnChanUpgradeOpen(ctx sdk.Context, portID, channelID str
 // OnChanUpgradeRestore implements the IBCModule interface
 func (im IBCMiddleware) OnChanUpgradeRestore(ctx sdk.Context, portID, channelID string) {}
 
-// OnChanUpgradeTimeout implements the IBCModule interface
-func (im IBCMiddleware) OnChanUpgradeTimeout(
-	ctx sdk.Context,
-	portID, channelID string,
-	counterpartyChannel channeltypes.Channel,
-	prevErrorReceipt channeltypes.ErrorReceipt,
-	proofCounterpartyChannel,
-	proofErrorReceipt []byte,
-	proofHeight ibcexported.Height,
-) error {
-	return im.app.OnChanUpgradeTimeout(ctx, portID, channelID, counterpartyChannel, prevErrorReceipt, proofCounterpartyChannel, proofErrorReceipt, proofHeight)
-}
-
 // SendPacket implements the ICS4 Wrapper interface
 func (im IBCMiddleware) SendPacket(
 	ctx sdk.Context,

modules/apps/27-interchain-accounts/host/ibc_module.go

@@ -169,16 +169,3 @@ func (im IBCModule) OnChanUpgradeOpen(ctx sdk.Context, portID, channelID string)
 
 // OnChanUpgradeRestore implements the IBCModule interface
 func (im IBCModule) OnChanUpgradeRestore(ctx sdk.Context, portID, channelID string) {}
-
-// OnChanUpgradeTimeout implements the IBCModule interface
-func (im IBCModule) OnChanUpgradeTimeout(
-	ctx sdk.Context,
-	portID, channelID string,
-	counterpartyChannel channeltypes.Channel,
-	prevErrorReceipt channeltypes.ErrorReceipt,
-	proofCounterpartyChannel,
-	proofErrorReceipt []byte,
-	proofHeight ibcexported.Height,
-) error {
-	return nil
-}

modules/apps/29-fee/ibc_middleware.go

@@ -345,19 +345,6 @@ func (im IBCMiddleware) OnChanUpgradeRestore(ctx sdk.Context, portID, channelID
 	im.app.OnChanUpgradeRestore(ctx, portID, channelID)
 }
 
-// OnChanUpgradeTimeout implements the IBCModule interface
-func (im IBCMiddleware) OnChanUpgradeTimeout(
-	ctx sdk.Context,
-	portID, channelID string,
-	counterpartyChannel channeltypes.Channel,
-	prevErrorReceipt channeltypes.ErrorReceipt,
-	proofCounterpartyChannel,
-	proofErrorReceipt []byte,
-	proofHeight exported.Height,
-) error {
-	return im.app.OnChanUpgradeTimeout(ctx, portID, channelID, counterpartyChannel, prevErrorReceipt, proofCounterpartyChannel, proofErrorReceipt, proofHeight)
-}
-
 // SendPacket implements the ICS4 Wrapper interface
 func (im IBCMiddleware) SendPacket(
 	ctx sdk.Context,

modules/apps/transfer/ibc_module.go

@@ -321,16 +321,3 @@ func (im IBCModule) OnChanUpgradeOpen(ctx sdk.Context, portID, channelID string)
 
 // OnChanUpgradeRestore implements the IBCModule interface
 func (im IBCModule) OnChanUpgradeRestore(ctx sdk.Context, portID, channelID string) {}
-
-// OnChanUpgradeTimeout implements the IBCModule interface
-func (im IBCModule) OnChanUpgradeTimeout(
-	ctx sdk.Context,
-	portID, channelID string,
-	counterpartyChannel channeltypes.Channel,
-	prevErrorReceipt channeltypes.ErrorReceipt,
-	proofCounterpartyChannel,
-	proofErrorReceipt []byte,
-	proofHeight ibcexported.Height,
-) error {
-	return nil
-}

modules/core/04-channel/keeper/export_test.go

@@ -35,8 +35,3 @@ func (k Keeper) ValidateUpgradeFields(ctx sdk.Context, proposedUpgrade types.Upg
 func (k Keeper) WriteUpgradeOpenChannel(ctx sdk.Context, portID, channelID string) {
 	k.writeUpgradeOpenChannel(ctx, portID, channelID)
 }
-
-// WriteUpgradeTimeoutChannel is a wrapper around writeUpgradeTimeoutChannel to allow the function to be directly called in tests.
-func (k Keeper) WriteUpgradeTimeoutChannel(ctx sdk.Context, portID, channelID string) error {
-	return k.writeUpgradeTimeoutChannel(ctx, portID, channelID)
-}

modules/core/04-channel/keeper/upgrade.go

@@ -463,13 +463,13 @@ func (k Keeper) ChanUpgradeTimeout(
 	return nil
 }
 
-// writeUpgradeTimeoutChannel restores the channel state of an initialising chain in the event that the counterparty chain has passed the timeout set in ChanUpgradeInit to the state before the upgrade was proposed.
+// WriteUpgradeTimeoutChannel restores the channel state of an initialising chain in the event that the counterparty chain has passed the timeout set in ChanUpgradeInit to the state before the upgrade was proposed.
 // Auxiliary upgrade state is also deleted.
 // An event is emitted for the handshake step.
-func (k Keeper) writeUpgradeTimeoutChannel(
+func (k Keeper) WriteUpgradeTimeoutChannel(
 	ctx sdk.Context,
 	portID, channelID string,
-) error {
+) {
 	defer telemetry.IncrCounter(1, "ibc", "channel", "upgrade-timeout")
 
 	channel, found := k.GetChannel(ctx, portID, channelID)
@@ -482,14 +482,10 @@ func (k Keeper) writeUpgradeTimeoutChannel(
 		panic(fmt.Sprintf("could not find existing upgrade when cancelling channel upgrade, channelID: %s, portID: %s", channelID, portID))
 	}
 
-	if err := k.AbortUpgrade(ctx, portID, channelID, types.NewUpgradeError(channel.UpgradeSequence, types.ErrUpgradeTimeout)); err != nil {
-		return errorsmod.Wrapf(types.ErrUpgradeRestoreFailed, "err: %v", err)
-	}
+	k.restoreChannel(ctx, portID, channelID, channel.UpgradeSequence, channel)
 
 	k.Logger(ctx).Info("channel state restored", "port-id", portID, "channel-id", channelID)
 	emitChannelUpgradeTimeoutEvent(ctx, portID, channelID, channel, upgrade)
-
-	return nil
 }
 
 // startFlushUpgradeHandshake will verify the counterparty proposed upgrade and the current channel state.

modules/core/04-channel/types/msgs.go

@@ -723,7 +723,7 @@ var _ sdk.Msg = &MsgChannelUpgradeTimeout{}
 func NewMsgChannelUpgradeTimeout(
 	portID, channelID string,
 	counterpartyChannel Channel,
-	errorReceipt ErrorReceipt,
+	errorReceipt *ErrorReceipt,
 	proofChannel, proofErrorReceipt []byte,
 	proofHeight clienttypes.Height,
 	signer string,

modules/core/04-channel/types/msgs_test.go

@@ -793,6 +793,16 @@ func (suite *TypesTestSuite) TestMsgChannelUpgradeTimeoutValidateBasic() {
 			func() {},
 			true,
 		},
+		{
+			"success with non-nil error receipt",
+			func() {
+				msg.PreviousErrorReceipt = &types.ErrorReceipt{
+					Sequence: 1,
+					Message:  "error message",
+				}
+			},
+			true,
+		},
 		{
 			"invalid port identifier",
 			func() {
@@ -835,7 +845,7 @@ func (suite *TypesTestSuite) TestMsgChannelUpgradeTimeoutValidateBasic() {
 		suite.Run(tc.name, func() {
 			msg = types.NewMsgChannelUpgradeTimeout(
 				ibctesting.MockPort, ibctesting.FirstChannelID,
-				types.Channel{State: types.OPEN}, types.ErrorReceipt{},
+				types.Channel{State: types.OPEN}, nil,
 				suite.proof, suite.proof,
 				height, addr,
 			)
@@ -858,7 +868,7 @@ func (suite *TypesTestSuite) TestMsgChannelUpgradeTimeoutGetSigners() {
 
 	msg := types.NewMsgChannelUpgradeTimeout(
 		ibctesting.MockPort, ibctesting.FirstChannelID,
-		types.Channel{}, types.ErrorReceipt{},
+		types.Channel{}, nil,
 		suite.proof, suite.proof,
 		height, addr,
 	)