Add e2e for changing controller params. #3872
Conversation
DimitrisJim
force-pushed
the
add-controller-e2e-params-test
branch
from
276ab26 to
6dc8e7d
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
DimitrisJim
force-pushed
the
add-controller-e2e-params-test
branch
2 times, most recently
from
f3f469c to
10d83ba
Compare
DimitrisJim
force-pushed
the
add-controller-e2e-params-test
branch
from
10d83ba to
b061b53
Compare
There was a problem hiding this comment.
Thank for adding this, @DimitrisJim. I left a bunch of minor suggestions.
And a question: should we add this test to the appropriate .json files for compatibility testing?
I've added this as a point to the epic in #2010 to keep track of it. IIRC this has only been done for 02-client so far so we can add these all together in a single PR. No problem adding here if its a preference. |
DimitrisJim
added
github_actions
| "github.com/cosmos/ibc-go/e2e/testsuite" | ||
| "github.com/cosmos/ibc-go/e2e/testvalues" | ||
| "github.com/strangelove-ventures/interchaintest/v7/ibc" | ||
| "github.com/stretchr/testify/suite" |
There was a problem hiding this comment.
a bit unconventional import structing. Usually its
// standard lib
// external imports
// ibc-go imports
but we haven't established a practice for individual go.mod's still within the ibc-go repo
There was a problem hiding this comment.
yeah I'll fix this up. Ideally we should add the same linting targets in the e2e makefile to have all go code follow a similar structure.
| "github.com/stretchr/testify/suite" | ||
| ) | ||
|
|
||
| func TestInterchainAccountsParamsTestSuite(t *testing.T) { |
There was a problem hiding this comment.
I guess we will need to add this to our compatibility test matrix
Description
closes: #2116
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.