From fb613b8349900f71c7bf01a929a4b6af839d566d Mon Sep 17 00:00:00 2001 From: mmsqe Date: Mon, 6 Nov 2023 09:22:54 +0800 Subject: [PATCH 1/2] fix expect pointer error when unmarshalling misbehaviour file --- CHANGELOG.md | 1 + modules/core/02-client/client/cli/tx.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4e935fb069e..e6a4265787d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -89,6 +89,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (testing) [\#4630](https://github.com/cosmos/ibc-go/pull/4630) Update `testconfig` to use revision formatted chain IDs. * (core/04-channel) [\#4706](https://github.com/cosmos/ibc-go/pull/4706) Retrieve correct next send sequence for packets in unordered channels. * (core/02-client) [\#4746](https://github.com/cosmos/ibc-go/pull/4746) Register implementations against `govtypes.Content` interface. +* (core/02-client) [\#](https://github.com/cosmos/ibc-go/pull/) Fix expect pointer error when unmarshalling misbehaviour file. ### Documentation diff --git a/modules/core/02-client/client/cli/tx.go b/modules/core/02-client/client/cli/tx.go index 46d46678742..19fd8b3f90b 100644 --- a/modules/core/02-client/client/cli/tx.go +++ b/modules/core/02-client/client/cli/tx.go @@ -161,7 +161,7 @@ func newSubmitMisbehaviourCmd() *cobra.Command { return fmt.Errorf("neither JSON input nor path to .json file for misbehaviour were provided: %w", err) } - if err := cdc.UnmarshalInterfaceJSON(contents, misbehaviour); err != nil { + if err := cdc.UnmarshalInterfaceJSON(contents, &misbehaviour); err != nil { return fmt.Errorf("error unmarshalling misbehaviour file: %w", err) } } From 88ed2c0489a959aab65067f9f509373fde0372ba Mon Sep 17 00:00:00 2001 From: mmsqe Date: Mon, 6 Nov 2023 09:24:58 +0800 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6a4265787d..b8dbfb9067f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -89,7 +89,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (testing) [\#4630](https://github.com/cosmos/ibc-go/pull/4630) Update `testconfig` to use revision formatted chain IDs. * (core/04-channel) [\#4706](https://github.com/cosmos/ibc-go/pull/4706) Retrieve correct next send sequence for packets in unordered channels. * (core/02-client) [\#4746](https://github.com/cosmos/ibc-go/pull/4746) Register implementations against `govtypes.Content` interface. -* (core/02-client) [\#](https://github.com/cosmos/ibc-go/pull/) Fix expect pointer error when unmarshalling misbehaviour file. +* (core/02-client) [\#5020](https://github.com/cosmos/ibc-go/pull/5020) Fix expect pointer error when unmarshalling misbehaviour file. ### Documentation