Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding interface assertions for app upgrade interface #5390

Merged
merged 2 commits into from
Dec 13, 2023
Merged

chore: adding interface assertions for app upgrade interface #5390

merged 2 commits into from
Dec 13, 2023

Conversation

damiannolan
Copy link
Member

Description

Missed them previously!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review December 12, 2023 17:11
@crodriguezvega crodriguezvega added the channel-upgradability Channel upgradability feature label Dec 13, 2023
crodriguezvega
crodriguezvega approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@damiannolan damiannolan enabled auto-merge (squash) December 13, 2023 10:36
@damiannolan damiannolan merged commit a99c84c into 04-channel-upgrades Dec 13, 2023
54 of 55 checks passed
@damiannolan damiannolan deleted the damian/add-interface-assertions branch December 13, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@charleenfei charleenfei Awaiting requested review from charleenfei

@colin-axner colin-axner Awaiting requested review from colin-axner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damiannolan @crodriguezvega @DimitrisJim