-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E test where unordered channel is used with ICA #5566
Merged
crodriguezvega
merged 18 commits into
feat/allow-unordered-ica-channels
from
cian/issue#5525-write-e2e-test-where-unordered-channel-is-used-with-ica
Jan 16, 2024
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8c5d4eb
test: add test to use an unordered ICA channel
chatton 70bfab9
Merge branch 'feat/allow-unordered-ica-channels' into cian/issue#5525…
chatton eab9665
chore: add hard coded UNORDERED channel Order
chatton 0d52300
proto: Add Order to MsgRegisterInterchainAccount.
DimitrisJim 9c5e9cf
Merge branch 'feat/allow-unordered-ica-channels' into cian/issue#5525…
chatton 535d04f
chore: apply proto changes to go files.
DimitrisJim d557981
Merge branch 'jim/5602-allow-specifying-order' into cian/issue#5525-w…
chatton ce7bf38
chore: apply proto changes to go files.
DimitrisJim f63092a
chore: e2e test passing with hard coded ordered value
chatton 9e80438
Add ordering to cli tx for Register.
DimitrisJim 7a36ca2
Add documentation line for tx now accepting ordering.
DimitrisJim 9e9aae6
Address feedback review.
DimitrisJim 12d5b8d
Address Cian's feedback; spacing.
DimitrisJim db3cff2
chore: merge #5602
chatton 63e08d5
chore: merge #5602
chatton 6003654
chore: merge feature branch
chatton 82a661d
Update e2e/tests/interchain_accounts/base_test.go
crodriguezvega 6c672b2
Merge branch 'feat/allow-unordered-ica-channels' into cian/issue#5525…
DimitrisJim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bummer 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this must be something to do with how the enum value is serialized with JSON or something maybe?
So
channeltypes.UNORDERED
evaluates toORDER_UNORDERED
in normal go code but here one of the relayers returns it asUnordered
? is it hermes?