Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): re-enable ica unordered channel upgrade #5756

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #5644

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega changed the title fix: re-enable ica unordered channel upgrade fix(e2e): re-enable ica unordered channel upgrade Jan 26, 2024
@crodriguezvega crodriguezvega added e2e channel-upgradability Channel upgradability feature priority PRs that need prompt reviews labels Jan 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (310a4bd) 81.49% compared to head (d531428) 81.54%.
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5756      +/-   ##
==========================================
+ Coverage   81.49%   81.54%   +0.05%     
==========================================
  Files         199      199              
  Lines       15203    15225      +22     
==========================================
+ Hits        12389    12415      +26     
+ Misses       2348     2344       -4     
  Partials      466      466              
Files Coverage Δ
modules/apps/transfer/keeper/relay.go 90.94% <100.00%> (ø)
modules/core/04-channel/keeper/keeper.go 90.90% <100.00%> (+0.13%) ⬆️
modules/core/04-channel/keeper/upgrade.go 92.58% <100.00%> (+0.27%) ⬆️
modules/core/04-channel/types/channel.go 100.00% <ø> (+6.15%) ⬆️
modules/core/04-channel/types/codec.go 100.00% <ø> (ø)

@crodriguezvega crodriguezvega marked this pull request as draft January 26, 2024 13:26
@crodriguezvega crodriguezvega marked this pull request as ready for review January 26, 2024 22:13
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woa, amazing, great job @crodriguezvega!

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/tests/interchain_accounts/base_test.go Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit 162eee2 into main Jan 29, 2024
64 checks passed
@crodriguezvega crodriguezvega deleted the carlos/re-enable-ica-unordered-upgrade-test branch January 29, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature e2e priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment e2e upgrade test for ica from ordered -> unordered channels
5 participants