Skip to content

Conversation

@aljo242
Copy link
Contributor

@aljo242 aljo242 commented Apr 1, 2025

Description

Updates ibc-go to support sdk v53 (using v0.53.x). I assume you will want to target another branch for this v11, but I am just opening for now so that it can be inspected.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@faddat
Copy link
Contributor

faddat commented Apr 1, 2025

Well this looks super great thank you

@faddat
Copy link
Contributor

faddat commented Apr 1, 2025

I think that if 53 is really a drop-in upgrade, then it probably makes the most sense to just release version 10 with 53

It also will not simply be inspected, it will be used. Thanks for this!

@faddat faddat mentioned this pull request Apr 1, 2025
10 tasks
@aljo242 aljo242 requested a review from womensrights as a code owner April 2, 2025 12:55
@womensrights womensrights mentioned this pull request Apr 14, 2025
1 task
@AdityaSripal
Copy link
Contributor

Does this already have all the necessary changes for supporting v0.53? Changes look good from an ibc-go perspective. Happy the changes are so simple! We'll target a new minor release of ibc-go v10.

If all the changes are in, we can resolve conflicts and merge. Let me know if we should take that part over

@aljo242
Copy link
Contributor Author

aljo242 commented Apr 15, 2025

Yes, this is all of the necessary changes!

@AdityaSripal AdityaSripal added this pull request to the merge queue Apr 17, 2025
Merged via the queue into cosmos:main with commit bd79edf Apr 17, 2025
53 checks passed
mergify bot pushed a commit that referenced this pull request Apr 17, 2025
* update

* preblocker

(cherry picked from commit bd79edf)
@mergify mergify bot mentioned this pull request Apr 17, 2025
10 tasks
AdityaSripal pushed a commit that referenced this pull request Apr 17, 2025
* update

* preblocker

(cherry picked from commit bd79edf)

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
DeshErBojhaa pushed a commit that referenced this pull request May 12, 2025
* update

* preblocker
DeshErBojhaa pushed a commit that referenced this pull request May 12, 2025
* update

* preblocker
DeshErBojhaa pushed a commit that referenced this pull request May 12, 2025
* update

* preblocker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants