Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde feature is not no_std compatible anymore #254

Closed
rnbguy opened this issue Nov 8, 2024 · 1 comment
Closed

serde feature is not no_std compatible anymore #254

rnbguy opened this issue Nov 8, 2024 · 1 comment

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented Nov 8, 2024 •
edited
Loading

#187 included cosmos-sdk-proto/serde into serde feature set.

ibc-proto-rs/Cargo.toml

Line 57 in bb44393

serde = ["dep:serde", "dep:informalsystems-pbjson", "ics23/serde", "cosmos-sdk-proto/serde"]

but cosmos-sdk-proto's serde feature includes tendermint-proto/std.

This makes the no-std ci jobs fail at cosmos/ibc-rs#1375

I think that the main issue that tendermint-proto doesn't have a serde feature. I opened PR to fix at cosmos-sdk-proto.
@rnbguy rnbguy mentioned this issue Nov 8, 2024
Closed
@rnbguy
Copy link
Collaborator Author

rnbguy commented Nov 9, 2024

closed in #255 via bumping the cosmos-sdk-proto dep.

@rnbguy rnbguy closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rnbguy