Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module::on_recv_packet_validate() #513

Closed
plafer opened this issue Mar 9, 2023 · 1 comment
Closed

Add Module::on_recv_packet_validate() #513

plafer opened this issue Mar 9, 2023 · 1 comment

Comments

@plafer
Copy link
Contributor

plafer commented Mar 9, 2023

          I initially left it as `*_execute` (and without any `*_validate`) because it turned out there was [nothing to validate](https://github.com/cosmos/ibc-rs/blob/abff7a98d0bb3d36735829db3e8673b2f2f6a4d5/crates/ibc/src/core/context/recv_packet.rs#L31) in the token transfer app. However I'm now realizing that I also removed it from the `Module` trait, which is the interface for *all* apps.

The solution is to add back on_recv_packet_validate() (and keep this as on_recv_packet_execute()). Let's do it in a separate PR.

Originally posted by @plafer in #512 (comment)

@plafer
Copy link
Contributor Author

plafer commented Mar 9, 2023

This is wrong, we don't need a on_recv_packet_validate(). See comment.

@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant