Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rust dependencies and replace failure with anyhow #38

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Upgrade rust dependencies and replace failure with anyhow #38

merged 2 commits into from
Mar 31, 2021

Conversation

devashishdxt
Copy link
Contributor

No description provided.

ethanfrey
ethanfrey approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

Also happy to replace anyhow with something simpler like thiserror which seems to be preferred these days. But that is a larger refactor and other PR.

@ethanfrey
Copy link
Contributor

No CI tests are running here... I guess I need to test manually before merge

@devashishdxt
Copy link
Contributor Author

This PR also fixes #37.

@ethanfrey
Copy link
Contributor

Tested locally, looks good. Thanks.

@ethanfrey ethanfrey merged commit 88a97ee into cosmos:master Mar 31, 2021
@ethanfrey
Copy link
Contributor

Tagged a v0.6.4 release and pushed a 0.6.4 crate for you to import.

@adizere adizere mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devashishdxt @ethanfrey