Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No ADR for the denom DOS fix #930

Closed
mpoke opened this issue May 8, 2023 · 2 comments · Fixed by #934
Closed

No ADR for the denom DOS fix #930

mpoke opened this issue May 8, 2023 · 2 comments · Fixed by #934
Assignees
@jtremback
Labels
scope: docs Improvements or additions to documentation

Comments

@mpoke
Copy link
Contributor

mpoke commented May 8, 2023

Problem

Releases https://github.com/cosmos/interchain-security/releases/tag/v1.1.0-multiden and https://github.com/cosmos/interchain-security/releases/tag/v1.2.0-multiden-rc0 bring to emergency fixes that deal with a DOS attack vector introduced by unblocking module accounts needed for the distribution protocol. There are not ADRs describing those fixes.

Closing criteria

The fixes are described in ADRs.
@mpoke mpoke added the scope: docs Improvements or additions to documentation label May 8, 2023
@mpoke mpoke added this to Cosmos Hub May 8, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub May 8, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub May 8, 2023
@jtremback
Copy link
Contributor

#934

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Cosmos Hub May 9, 2023
@mpoke mpoke moved this from ✅ Done to 👀 In review in Cosmos Hub May 10, 2023
@mpoke
Copy link
Contributor Author

mpoke commented May 10, 2023

Let's keep it open until we merge the PR.

@mpoke mpoke reopened this May 10, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to 🩹 Triage in Cosmos Hub May 10, 2023
@mpoke mpoke mentioned this issue May 10, 2023
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Cosmos Hub Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtremback jtremback

Labels
scope: docs Improvements or additions to documentation
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Create adr-004-denom-dos-fixes.md cosmos/interchain-security
2 participants
@jtremback @mpoke