fix: lint only

[faddat]

Description

Strictly lint the code with Revive.

We use this at Notional to work with large volumes of code more quickly.

• removes gosec action
• runs gosec in golangci-lint
• Adds standard linters
• adds a vscode config

Linked issues

This PR should be merged before:

• Remove Ignite CLI #796
• feat: use 45.15 #795
• upgrade sdk47 #800

Type of change

If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!

• Feature: Changes and/or adds code behavior, irrelevant to bug fixes
• Fix: Changes and/or adds code behavior, specifically to fix a bug
• Refactor: Changes existing code style, naming, structure, etc.
• Testing: Adds testing
• Docs: Adds documentation

Regression tests

If Refactor, describe the new or existing tests that verify no behavior was changed or added where refactors were introduced.

New behavior tests

If Feature or Fix, describe the new or existing tests that verify the new behavior is correct and expected.

Versioning Implications

• This PR will affect semantic versioning as defined for ICS

If the above box is checked, which version should be bumped?

• MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)
• MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)
• PATCH: Non consensus breaking changes

Targeting

Please select one of the following:

• This PR is only relevant to main
• This PR is relevant to main, and should also be back-ported to ____ (ex: v1.0.0 and v1.1.0)
• This PR is only relevant to ____ (ex: v1.0.0, v1.1.0, and v1.2.0)

[faddat]

make test  1 ✘  3s 
go test ./... && go run ./tests/integration/...
? github.com/cosmos/interchain-security/app/consumer [no test files]
ok github.com/cosmos/interchain-security/app/consumer/ante 0.024s
? github.com/cosmos/interchain-security/app/provider [no test files]
? github.com/cosmos/interchain-security/cmd/interchain-security-cd [no test files]
? github.com/cosmos/interchain-security/cmd/interchain-security-cdd [no test files]
? github.com/cosmos/interchain-security/cmd/interchain-security-pd [no test files]
? github.com/cosmos/interchain-security/legacy_ibc_testing/core [no test files]
? github.com/cosmos/interchain-security/legacy_ibc_testing/simapp/helpers [no test files]
? github.com/cosmos/interchain-security/legacy_ibc_testing/simapp [no test files]
? github.com/cosmos/interchain-security/legacy_ibc_testing/testing [no test files]
? github.com/cosmos/interchain-security/tests/integration [no test files]
? github.com/cosmos/interchain-security/testutil/crypto [no test files]
? github.com/cosmos/interchain-security/testutil/ibc_testing [no test files]
? github.com/cosmos/interchain-security/testutil/keeper [no test files]
? github.com/cosmos/interchain-security/testutil/simibc [no test files]
? github.com/cosmos/interchain-security/x/ccv/consumer/client/cli [no test files]
? github.com/cosmos/interchain-security/x/ccv/democracy/distribution [no test files]
? github.com/cosmos/interchain-security/x/ccv/democracy/staking [no test files]
? github.com/cosmos/interchain-security/x/ccv/democracy/governance [no test files]
? github.com/cosmos/interchain-security/x/ccv/provider/client [no test files]
? github.com/cosmos/interchain-security/x/ccv/provider/client/cli [no test files]
ok github.com/cosmos/interchain-security/app/consumer-democracy 0.044s
ok github.com/cosmos/interchain-security/app/consumer-democracy/ante 0.022s
ok github.com/cosmos/interchain-security/tests/difference/core/driver 1.338s
ok github.com/cosmos/interchain-security/tests/e2e 154.070s
ok github.com/cosmos/interchain-security/testutil/e2e 52.291s
ok github.com/cosmos/interchain-security/x/ccv/consumer 0.023s
ok github.com/cosmos/interchain-security/x/ccv/consumer/keeper 0.022s
ok github.com/cosmos/interchain-security/x/ccv/consumer/types 0.021s
ok github.com/cosmos/interchain-security/x/ccv/provider 0.037s
ok github.com/cosmos/interchain-security/x/ccv/provider/keeper 2.121s
ok github.com/cosmos/interchain-security/x/ccv/provider/types 0.019s
ok github.com/cosmos/interchain-security/x/ccv/types (cached)
ok github.com/cosmos/interchain-security/x/ccv/utils 0.017s
=============== building default testRun ===============
=============== started default tests ===============
running default: step 1 == StartChainAction
running default: step 2 == submitConsumerAdditionProposalAction
running default: step 3 == assignConsumerPubKeyAction
running default: step 4 == assignConsumerPubKeyAction
running default: step 5 == assignConsumerPubKeyAction
running default: step 6 == voteGovProposalAction
running default: step 7 == startConsumerChainAction
running default: step 8 == addIbcConnectionAction
running default: step 9 == addIbcChannelAction
running default: step 10 == delegateTokensAction
running default: step 11 == SendTokensAction
running default: step 12 == relayPacketsAction
running default: step 13 == SendTokensAction
running default: step 14 == assignConsumerPubKeyAction
running default: step 15 == relayPacketsAction
running default: step 16 == unbondTokensAction
running default: step 17 == relayPacketsAction
running default: step 18 == redelegateTokensAction
running default: step 19 == relayPacketsAction
running default: step 20 == downtimeSlashAction
running default: step 21 == relayPacketsAction
running default: step 22 == relayPacketsAction
running default: step 23 == unjailValidatorAction
running default: step 24 == relayPacketsAction
running default: step 25 == downtimeSlashAction
running default: step 26 == relayPacketsAction
running default: step 27 == unjailValidatorAction
running default: step 28 == relayPacketsAction
running default: step 29 == submitEquivocationProposalAction
running default: step 30 == doublesignSlashAction
running default: step 31 == relayPacketsAction
running default: step 32 == doublesignSlashAction
running default: step 33 == relayPacketsAction
running default: step 34 == relayPacketsAction
running default: step 35 == submitEquivocationProposalAction
running default: step 36 == voteGovProposalAction
running default: step 37 == relayPacketsAction
running default: step 38 == submitConsumerRemovalProposalAction
running default: step 39 == voteGovProposalAction
=============== finished default tests in 6m16.078905088s ===============
=============== tearing down default testRun ===============
=============== building democracy testRun ===============
=============== started democracy tests ===============
running democracy: step 1 == StartChainAction
running democracy: step 2 == submitConsumerAdditionProposalAction
running democracy: step 3 == assignConsumerPubKeyAction
running democracy: step 4 == assignConsumerPubKeyAction
running democracy: step 5 == assignConsumerPubKeyAction
running democracy: step 6 == voteGovProposalAction
running democracy: step 7 == startConsumerChainAction
running democracy: step 8 == addIbcConnectionAction
running democracy: step 9 == addIbcChannelAction
running democracy: step 10 == transferChannelCompleteAction
running democracy: step 11 == delegateTokensAction
running democracy: step 12 == SendTokensAction
running democracy: step 13 == relayPacketsAction
running democracy: step 14 == SendTokensAction
running democracy: step 15 == registerRepresentativeAction
running democracy: step 16 == delegateTokensAction
running democracy: step 17 == submitParamChangeProposalAction
running democracy: step 18 == voteGovProposalAction
running democracy: step 19 == relayRewardPacketsToProviderAction
running democracy: step 20 == downtimeSlashAction
running democracy: step 21 == relayPacketsAction
running democracy: step 22 == relayPacketsAction
running democracy: step 23 == unjailValidatorAction
running democracy: step 24 == relayPacketsAction
=============== finished democracy tests in 3m46.854496221s ===============
=============== tearing down democracy testRun ===============
=============== building slash-throttling testRun ===============
=============== started slash-throttling tests ===============
running slash-throttling: step 1 == StartChainAction
running slash-throttling: step 2 == submitConsumerAdditionProposalAction
running slash-throttling: step 3 == assignConsumerPubKeyAction
running slash-throttling: step 4 == assignConsumerPubKeyAction
running slash-throttling: step 5 == assignConsumerPubKeyAction
running slash-throttling: step 6 == voteGovProposalAction
running slash-throttling: step 7 == startConsumerChainAction
running slash-throttling: step 8 == addIbcConnectionAction
running slash-throttling: step 9 == addIbcChannelAction
running slash-throttling: step 10 == delegateTokensAction
running slash-throttling: step 11 == SendTokensAction
running slash-throttling: step 12 == relayPacketsAction
running slash-throttling: step 13 == SendTokensAction
running slash-throttling: step 14 == downtimeSlashAction
running slash-throttling: step 15 == downtimeSlashAction
running slash-throttling: step 16 == relayPacketsAction
running slash-throttling: step 17 == slashThrottleDequeue
running slash-throttling: step 18 == relayPacketsAction
running slash-throttling: step 19 == submitConsumerRemovalProposalAction
running slash-throttling: step 20 == voteGovProposalAction
=============== finished slash-throttling tests in 5m5.782479876s ===============
=============== tearing down slash-throttling testRun ===============
TOTAL TIME ELAPSED: 17m54.818272708s

[faddat]

ref:

• style: enable strict gofumpt cosmos-sdk#15579