CBG-3392 match CAS checks for xattrs like CBS does #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches CBS behavior and allows all SG tests to pass.
I found the logic in
checkCASXattrto be really confusing and I'm not sure how to make it easier.Formerly, a document was declared a tombstone based on whether it has nil document body. However, having a nil document body is a valid state for a document, so I added field to determine whether it is a tombstone. I didn't write a schema migration to add this field since we have no released version of SG that can use a persistent rosmar database.
I switched some bitflags to an options struct to make it easier to read and more idiomatic in go, rather than add two new flags.
This passes all tests in Sync Gateway, including the ones that are currently skipped.