Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3627 implement hlc for each bucket #23

Merged
merged 4 commits into from
Dec 20, 2023
Merged

CBG-3627 implement hlc for each bucket #23

merged 4 commits into from
Dec 20, 2023

Conversation

torcolvin
Copy link
Collaborator

  • there is more locking than seems necessary here, but I don't think this will be in contention, especially becuase these are inside SQL transactions that are happening one at a time
  • each bucket maintains it's own HLC, as it is stored inside the bucket db, and so needs to be re-initialized from the last possible clock that was serialized.

@torcolvin
CBG-3627 implement hlc
46b8751 
- there is more locking than seems necessary here, but I don't think
  this will be in contention, especially becuase these are inside SQL
  transactions that are happening one at a time
- each bucket maintains it's own HLC, as it is stored inside the bucket
  db, and so needs to be re-initialized from the last possible clock
  that was serialized.
@adamcfraser adamcfraser assigned torcolvin and unassigned adamcfraser Dec 15, 2023
adamcfraser
adamcfraser requested changes Dec 19, 2023
View reviewed changes
hlc.go Outdated Show resolved Hide resolved
@torcolvin torcolvin assigned adamcfraser and unassigned torcolvin Dec 20, 2023
adamcfraser
adamcfraser approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamcfraser adamcfraser merged commit 6696677 into main Dec 20, 2023
12 checks passed
@adamcfraser adamcfraser deleted the CBG-3627 branch December 20, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @adamcfraser