From a10f8e7781821e3cab73e7b316c7966835401eec Mon Sep 17 00:00:00 2001 From: Felix Perron-Brault Date: Fri, 15 Nov 2024 15:46:44 -0500 Subject: [PATCH] clean up https://coveord.atlassian.net/browse/KIT-3528 --- package-lock.json | 3 ++- packages/atomic/package.json | 2 +- .../search/facets/atomic-facet/e2e/atomic-facet.e2e.ts | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index d8c75139d0..9e4e09282e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -41867,6 +41867,7 @@ "version": "4.0.0", "resolved": "https://registry.npmjs.org/natural-orderby/-/natural-orderby-4.0.0.tgz", "integrity": "sha512-IKbGiBbsEis4F0JuAoERsLwVwVwExW20e7vwo0G4n00cWOIuHRwjv7dONoXKW1PfxRnWxwywmg1FA5ivyv170g==", + "dev": true, "license": "MIT", "engines": { "node": ">=18" @@ -54163,7 +54164,6 @@ "i18next": "23.12.2", "i18next-http-backend": "2.5.2", "marked": "12.0.2", - "natural-orderby": "4.0.0", "stencil-inline-svg": "1.1.0", "ts-debounce": "^4.0.0" }, @@ -54225,6 +54225,7 @@ "lit-html": "3.1.4", "local-web-server": "5.4.0", "lodash": "4.17.21", + "natural-orderby": "4.0.0", "ncp": "2.0.0", "postcss-focus-visible": "9.0.1", "postcss-import": "16.1.0", diff --git a/packages/atomic/package.json b/packages/atomic/package.json index 75418f245b..4481d5f3f8 100644 --- a/packages/atomic/package.json +++ b/packages/atomic/package.json @@ -77,7 +77,6 @@ "i18next": "23.12.2", "i18next-http-backend": "2.5.2", "marked": "12.0.2", - "natural-orderby": "4.0.0", "stencil-inline-svg": "1.1.0", "ts-debounce": "^4.0.0" }, @@ -139,6 +138,7 @@ "lit-html": "3.1.4", "local-web-server": "5.4.0", "lodash": "4.17.21", + "natural-orderby": "4.0.0", "ncp": "2.0.0", "postcss-focus-visible": "9.0.1", "postcss-import": "16.1.0", diff --git a/packages/atomic/src/components/search/facets/atomic-facet/e2e/atomic-facet.e2e.ts b/packages/atomic/src/components/search/facets/atomic-facet/e2e/atomic-facet.e2e.ts index 2082fd0692..46e25058e9 100644 --- a/packages/atomic/src/components/search/facets/atomic-facet/e2e/atomic-facet.e2e.ts +++ b/packages/atomic/src/components/search/facets/atomic-facet/e2e/atomic-facet.e2e.ts @@ -169,12 +169,12 @@ const sortCriteriaTests: { { criteria: 'alphanumericNatural', sortFunction: (values: string[]) => - orderBy(values, [(value) => value], 'asc'), + orderBy([...values], [(value) => value], 'asc'), }, { criteria: 'alphanumericNaturalDescending', sortFunction: (values: string[]) => - orderBy(values, [(value) => value], ['desc']), + orderBy([...values], [(value) => value], ['desc']), }, ];