Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(commerce ssr): setup smoke tests on commerce SSR sample #4665

Merged
merged 26 commits into from
Nov 19, 2024
Merged

test(commerce ssr): setup smoke tests on commerce SSR sample #4665

merged 26 commits into from
Nov 19, 2024

Conversation

fpbrault
Copy link
Contributor

This PR adds smoke tests for the headless commerce SSR sample.

https://coveord.atlassian.net/browse/KIT-3410

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 241.3 241.3 0
commerce 346 346 0
search 412.9 412.9 0
insight 403.6 403.6 0
recommendation 253.5 253.5 0
ssr 406.4 406.4 0
ssr-commerce 358.2 358.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fpbrault fpbrault marked this pull request as ready for review November 12, 2024 16:41
@fpbrault fpbrault requested a review from a team as a code owner November 12, 2024 16:41
louis-bompart
louis-bompart reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the tests do work, I don't see how they would fail if the SSR part of the SSR would fail?

@fpbrault fpbrault marked this pull request as draft November 13, 2024 14:10
@fpbrault fpbrault marked this pull request as ready for review November 18, 2024 16:40
louis-bompart
louis-bompart approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

packages/samples/headless-ssr-commerce/e2e/search/search.spec.ts Show resolved Hide resolved
@fpbrault fpbrault added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 6550a8e Nov 19, 2024
122 checks passed
@fpbrault fpbrault deleted the KIT-3410 branch November 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpbrault @louis-bompart @alexprudhomme