Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quantic): Exposed the options to be be passed in Did You Mean controller in the QuanticDidYouMean component #4682

Merged
merged 21 commits into from
Nov 21, 2024
Merged

feat(quantic): Exposed the options to be be passed in Did You Mean controller in the QuanticDidYouMean component #4682

merged 21 commits into from
Nov 21, 2024

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Nov 18, 2024 •
edited
Loading

SFINT-5681

IN THIS PR:

  • Exposed disableQueryAutoCorrection and queryCorrectionMode properties in the QuanticDidYouMean component.
  • Added unit tests
  • Fixed issue with props in the controller of the did-you-mean feature for insight

Notes:

  • This needs to be merge after this PR
  • We are setting queryCorrectionMode to legacy to avoid breaking changes. This will be changed after the next major release, we have the jira tickets to eventually change that.

TESTS:

image

@SimonMilord SimonMilord changed the base branch from master to SFINT-5680 November 18, 2024 18:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 241.3 241.3 0
commerce 346 346 0
search 412.9 412.9 0
insight 403.6 403.7 0
recommendation 253.5 253.5 0
ssr 406.4 406.4 0
ssr-commerce 358.2 358.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@SimonMilord SimonMilord marked this pull request as ready for review November 18, 2024 20:46
@SimonMilord SimonMilord requested a review from a team as a code owner November 18, 2024 20:46
@SimonMilord SimonMilord requested review from erocheleau and mmitiche and removed request for a team November 18, 2024 20:46
Base automatically changed from SFINT-5680 to master November 18, 2024 22:28
@SimonMilord SimonMilord requested a review from a team as a code owner November 18, 2024 22:28
erocheleau
erocheleau reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the renaming of the property everything seems good!

I think you could add to this PR the change to the defaultDidYouMeanOptions we discussed in slack.

packages/headless/src/controllers/insight/did-you-mean/headless-insight-did-you-mean.ts Outdated Show resolved Hide resolved
packages/quantic/force-app/main/default/lwc/quanticDidYouMean/quanticDidYouMean.js Outdated Show resolved Hide resolved
packages/quantic/force-app/main/default/lwc/quanticDidYouMean/quanticDidYouMean.js Outdated Show resolved Hide resolved
mmitiche
mmitiche reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change Alert 🚨

packages/quantic/force-app/main/default/lwc/quanticDidYouMean/quanticDidYouMean.js Outdated Show resolved Hide resolved
mmitiche
mmitiche approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good to me,

couple remarks about the unit tests to be addressed.

...ges/quantic/force-app/main/default/lwc/quanticDidYouMean/__tests__/quanticDidYouMean.test.js Show resolved Hide resolved
...ges/quantic/force-app/main/default/lwc/quanticDidYouMean/__tests__/quanticDidYouMean.test.js Outdated Show resolved Hide resolved
@SimonMilord SimonMilord added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit 4ccf316 Nov 21, 2024
122 checks passed
@SimonMilord SimonMilord deleted the SFINT-5681 branch November 21, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitiche mmitiche mmitiche approved these changes

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@erocheleau erocheleau Awaiting requested review from erocheleau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonMilord @erocheleau @alexprudhomme @mmitiche